📖 Proposal for two new AWS self-managed cluster feature gates #5276

mzazrivec · 2025-01-13T15:55:54Z

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes
This proposal should be approved before #5124 can be implemented.

Special notes for your reviewer:

Checklist:

Release note:

k8s-ci-robot · 2025-01-13T15:55:57Z

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-01-13T15:56:01Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dlipovetsky for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-01-13T15:56:04Z

Hi @mzazrivec. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

serngawy · 2025-01-13T21:36:05Z

docs/proposal/2025-01-07-aws-self-managed-feature-gates.md

+
+## Proposal
+
+- Introduce AWSMachine feature gate which would turn on and off the AWSMachineReconciler. The feature gate would be on by default.


Suggested change

- Introduce AWSMachine feature gate which would turn on and off the AWSMachineReconciler. The feature gate would be on by default.

- Introduce AWSMachine feature gate which would turn on and off the AWSMachineReconciler. The feature gate would be enabled by default.

serngawy · 2025-01-13T21:37:00Z

docs/proposal/2025-01-07-aws-self-managed-feature-gates.md

+## Proposal
+
+- Introduce AWSMachine feature gate which would turn on and off the AWSMachineReconciler. The feature gate would be on by default.
+- Introduce AWSCluster feature gate which would turn on and off the AWSClusterReconciler. The feature gate would be on by default.


Suggested change

- Introduce AWSCluster feature gate which would turn on and off the AWSClusterReconciler. The feature gate would be on by default.

- Introduce AWSCluster feature gate which would turn on and off the AWSClusterReconciler. The feature gate would be enabled by default.

serngawy · 2025-01-13T21:45:28Z

docs/proposal/2025-01-07-aws-self-managed-feature-gates.md

+
+- change any of the existing feature gates or their semantics
+
+## Proposal


Please explain; where is changes will happen in the code , ex ; a new featureGate with name: selfManagedAWSCluster , default: true will be defined here as well as where is the changes will happen in the manager main to enable?disable those features

Please explain the dependency between those 2 new featureGates; you cannot have the AWSMachine while the AWSCluster is disabled.
How do you will handle this case if endUser enabled the AWSMachine without AWSCluster ?

Also explain what possible risks if the endUser disable those FeatureGates while the AWSCluster OR AWSMachine CRs are reconciling. Might be good to mentioned that endUser can enable the AWSCluster with MachinePool while disable the AWSMachine feature.

serngawy · 2025-01-13T21:47:09Z

docs/proposal/2025-01-07-aws-self-managed-feature-gates.md

+- Introduce AWSCluster feature gate which would turn on and off the AWSClusterReconciler. The feature gate would be on by default.
+
+### User Stories
+


another user stories is as endUser I want to use EKS only or ROSA only OR EKS & ROSA without enabling AWS self-managed clusters

serngawy · 2025-01-13T21:50:48Z

docs/proposal/2025-01-07-aws-self-managed-feature-gates.md

+
+## Alternatives
+
+The alternative here would be simply not to implement the two new feature gates and rely just on namespace separation.


Another alternative is user can use labels to let the controllers only watch certain CRs that have the labels. However, this not completely satisfy the case as the controllers is still enabled.

serngawy · 2025-01-13T21:52:23Z

docs/proposal/2025-01-07-aws-self-managed-feature-gates.md

+
+## Upgrade Strategy
+
+CAPA upgrades should not be affected. Existing deployments will not notice anything different, because the two new feature gates will be on by default (current behavior).


Please explain that with upgrade user should expect to see 2 new featureGates has been added to the CAPA deployment with default is true

serngawy · 2025-01-13T21:54:19Z

docs/proposal/2025-01-07-aws-self-managed-feature-gates.md

+
+1. Ability to enable / disable feature gates for AWSCluster and AWSMachine controllers.
+2. Both feature gates would be on by default.
+


We need to inform the endUser in case enabling the AWSMachine feature gate without enabling the AWSCluster feature gate.

serngawy · 2025-01-15T14:34:46Z

please include emojis in the PR title so the verify job can pass

serngawy · 2025-01-15T15:41:29Z

/ok-to-test

nrb · 2025-01-20T17:08:10Z

docs/proposal/2025-01-07-aws-self-managed-feature-gates.md

+title: Feature gates for AWSCluster and AWSMachine
+authors:
+  - "@mzazrivec"
+reviewers:


Add me as well - @nrb

nrb · 2025-01-20T17:10:43Z

Will give this a proper review, but we agreed in the Jan 20, 2025 community call to set lazy consensus for 1 week. If no major objections to this, we'll merge on Jan 27, 2025.

AndiDog

Fine for me. Just some wording comments.

AndiDog · 2025-01-22T15:22:01Z

docs/proposal/2025-01-07-aws-self-managed-feature-gates.md

+
+## Motivation
+
+Motivation for the two new feature gates is the option to turn on and off CAPA's ability to reconcile AWSMachine and AWSCluster resources for AWS self-managed clusters. Currently, controllers for these two resource types are always on.


Do you mean EKS clusters? The words "self-managed", "managed" and "unmanaged" are quite ambiguous already and I'd avoid them.

Fair enough, fixed.

AndiDog · 2025-01-22T15:22:47Z

docs/proposal/2025-01-07-aws-self-managed-feature-gates.md

+
+Motivation for the two new feature gates is the option to turn on and off CAPA's ability to reconcile AWSMachine and AWSCluster resources for AWS self-managed clusters. Currently, controllers for these two resource types are always on.
+
+The possibility to turn the respective controllers on and of becomes important in multi-tenant CAPA installations (more than one CAPA installed in a single kubernetes cluster). The two new feature gates in will help to avoid interferences and conflicts between the controllers during resource reconciliations.


Suggested change

The possibility to turn the respective controllers on and of becomes important in multi-tenant CAPA installations (more than one CAPA installed in a single kubernetes cluster). The two new feature gates in will help to avoid interferences and conflicts between the controllers during resource reconciliations.

The possibility to turn the respective controllers on and off becomes important in multi-tenant CAPA installations (more than one CAPA installed in a single kubernetes cluster). The two new feature gates will help avoid interference and conflicts between the controllers during resource reconciliations.

AndiDog · 2025-01-22T15:23:33Z

docs/proposal/2025-01-07-aws-self-managed-feature-gates.md

+
+## Implementation History
+
+- [ ] 01/20/2025: Proposed idea in an issue or [community meeting]


Suggested change

- [ ] 01/20/2025: Proposed idea in an issue or [community meeting]

- [ ] 2025-01-20: Proposed idea in an issue or [community meeting]

Fixed as well, thank you.

k8s-ci-robot requested review from AndiDog and dlipovetsky January 13, 2025 15:56

k8s-ci-robot added needs-priority needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 13, 2025

mzazrivec changed the title ~~Proposal for two new AWS self-managed cluster feature gates~~ WIP: Proposal for two new AWS self-managed cluster feature gates Jan 13, 2025

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025

serngawy suggested changes Jan 13, 2025

View reviewed changes

mzazrivec force-pushed the proposal_for_granularity_switch branch from b217164 to a6f6503 Compare January 15, 2025 14:06

mzazrivec changed the title ~~WIP: Proposal for two new AWS self-managed cluster feature gates~~ 📖 Proposal for two new AWS self-managed cluster feature gates Jan 15, 2025

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2025

nrb reviewed Jan 20, 2025

View reviewed changes

mzazrivec force-pushed the proposal_for_granularity_switch branch from a6f6503 to 4c5c448 Compare January 21, 2025 12:21

AndiDog reviewed Jan 22, 2025

View reviewed changes

Proposal for AWS self-managed cluster feature gates

bcd1079

mzazrivec force-pushed the proposal_for_granularity_switch branch from 4c5c448 to bcd1079 Compare January 24, 2025 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

📖 Proposal for two new AWS self-managed cluster feature gates #5276

📖 Proposal for two new AWS self-managed cluster feature gates #5276

mzazrivec commented Jan 13, 2025 •

edited

Loading

k8s-ci-robot commented Jan 13, 2025

k8s-ci-robot commented Jan 13, 2025

k8s-ci-robot commented Jan 13, 2025

serngawy Jan 13, 2025

serngawy Jan 13, 2025

serngawy Jan 13, 2025

serngawy Jan 13, 2025

serngawy Jan 13, 2025

serngawy Jan 13, 2025

serngawy Jan 13, 2025

serngawy commented Jan 15, 2025

serngawy commented Jan 15, 2025

nrb Jan 20, 2025

mzazrivec Jan 21, 2025

nrb commented Jan 20, 2025

AndiDog left a comment

AndiDog Jan 22, 2025

mzazrivec Jan 24, 2025

AndiDog Jan 22, 2025

mzazrivec Jan 24, 2025

AndiDog Jan 22, 2025

mzazrivec Jan 24, 2025


		## Proposal

		- Introduce AWSMachine feature gate which would turn on and off the AWSMachineReconciler. The feature gate would be on by default.

	- Introduce AWSCluster feature gate which would turn on and off the AWSClusterReconciler. The feature gate would be on by default.
	- Introduce AWSCluster feature gate which would turn on and off the AWSClusterReconciler. The feature gate would be enabled by default.


		- change any of the existing feature gates or their semantics

		## Proposal

		- Introduce AWSCluster feature gate which would turn on and off the AWSClusterReconciler. The feature gate would be on by default.

		### User Stories


		## Alternatives

		The alternative here would be simply not to implement the two new feature gates and rely just on namespace separation.


		## Upgrade Strategy

		CAPA upgrades should not be affected. Existing deployments will not notice anything different, because the two new feature gates will be on by default (current behavior).


		1. Ability to enable / disable feature gates for AWSCluster and AWSMachine controllers.
		2. Both feature gates would be on by default.


		## Motivation

		Motivation for the two new feature gates is the option to turn on and off CAPA's ability to reconcile AWSMachine and AWSCluster resources for AWS self-managed clusters. Currently, controllers for these two resource types are always on.


		Motivation for the two new feature gates is the option to turn on and off CAPA's ability to reconcile AWSMachine and AWSCluster resources for AWS self-managed clusters. Currently, controllers for these two resource types are always on.

		The possibility to turn the respective controllers on and of becomes important in multi-tenant CAPA installations (more than one CAPA installed in a single kubernetes cluster). The two new feature gates in will help to avoid interferences and conflicts between the controllers during resource reconciliations.


		## Implementation History

		- [ ] 01/20/2025: Proposed idea in an issue or [community meeting]

	- [ ] 01/20/2025: Proposed idea in an issue or [community meeting]
	- [ ] 2025-01-20: Proposed idea in an issue or [community meeting]

📖 Proposal for two new AWS self-managed cluster feature gates #5276

Are you sure you want to change the base?

📖 Proposal for two new AWS self-managed cluster feature gates #5276

Conversation

mzazrivec commented Jan 13, 2025 • edited Loading

k8s-ci-robot commented Jan 13, 2025

k8s-ci-robot commented Jan 13, 2025

k8s-ci-robot commented Jan 13, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

serngawy commented Jan 15, 2025

serngawy commented Jan 15, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nrb commented Jan 20, 2025

AndiDog left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mzazrivec commented Jan 13, 2025 •

edited

Loading