Skip to content

🐛 Use external CCM in Flatcar template #5099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2024
Merged

🐛 Use external CCM in Flatcar template #5099

merged 1 commit into from
Sep 2, 2024

Conversation

ader1990
Copy link
Contributor

@ader1990 ader1990 commented Aug 19, 2024 •
edited
Loading

Backport the changes from 37e7814 to the Flatcar template.

Without this change, the Flatcar based cluster will not reach a fully provisioned state, as Calico or any other CNI cannot be deployed, as all the worker nodes are tainted with uninitialized label.

What type of PR is this?

Add one of the following kinds:

/kind bug

Update Flatcar template to use external CCM.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Aug 19, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @ader1990!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @ader1990. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 19, 2024
@ader1990 ader1990 force-pushed the fix-flatcar-template branch from afb324e to a75b8fa Compare August 19, 2024 08:58
@AndiDog
Copy link
Contributor

AndiDog commented Aug 21, 2024

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2024
@AndiDog
Copy link
Contributor

AndiDog commented Aug 23, 2024

There seems to be no test for these templates. I diffed it manually and it looks good compared to the non-Flatcar template.

The build failure seems to be unrelated.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2024
@AndiDog
Copy link
Contributor

AndiDog commented Aug 23, 2024

@ader1990 can you try force-pushing the commit, so the "PR verify" step re-runs? Maybe it succeeds at the retry 🤷.

@AndiDog
Copy link
Contributor

AndiDog commented Aug 23, 2024

@ader1990 can you try force-pushing the commit, so the "PR verify" step re-runs? Maybe it succeeds at the retry 🤷.

Scratch that. The action is set to not re-run. I'm discussing with maintainers how to fix this.

@ader1990
Use external CCM in Flatcar template
1c37ea4 
Backport the changes from kubernetes-sigs@37e7814 to the Flatcar template.

Signed-off-by: Adrian Vladu <[email protected]>
@ader1990 ader1990 force-pushed the fix-flatcar-template branch from a75b8fa to 1c37ea4 Compare September 2, 2024 07:55
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2024
@ader1990
Copy link
Contributor Author

ader1990 commented Sep 2, 2024

@ader1990 can you try force-pushing the commit, so the "PR verify" step re-runs? Maybe it succeeds at the retry 🤷.

Hello, I rebased it nonetheless. Please let me know if there is anything I can do, maybe I should close the PR and open a new one?

@AndiDog
Copy link
Contributor

AndiDog commented Sep 2, 2024

Sorry, after the CI fix, a rebase onto latest main is needed (see also chat).

@ader1990
Copy link
Contributor Author

ader1990 commented Sep 2, 2024

Sorry, after the CI fix, a rebase onto latest main is needed (see also chat).

Hello, I did a rebase on main already, see: https://github.com/ader1990/cluster-api-provider-aws/commits/fix-flatcar-template/.

@AndiDog
Copy link
Contributor

AndiDog commented Sep 2, 2024

Sorry, after the CI fix, a rebase onto latest main is needed (see also chat).

Hello, I did a rebase on main already, see: https://github.com/ader1990/cluster-api-provider-aws/commits/fix-flatcar-template/.

Ah, I see now what the issue is. Thought it was the same CI problem as before.

Error: failed: No matching PR type indicator found in title.

Please add the respective emoji to the PR title, as requested in the PR template checklist.

@AndiDog
Copy link
Contributor

AndiDog commented Sep 2, 2024

/test pull-cluster-api-provider-aws-test

@ader1990 ader1990 changed the title Use external CCM in Flatcar template 🐛 Use external CCM in Flatcar template Sep 2, 2024
@AndiDog
Copy link
Contributor

AndiDog commented Sep 2, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndiDog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ae3323c into kubernetes-sigs:main Sep 2, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi Awaiting requested review from chrischdi

@damdo damdo Awaiting requested review from damdo

Assignees

@AndiDog AndiDog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ader1990 @k8s-ci-robot @AndiDog