✨ SubnetSchema support #4971

krasoffski · 2024-05-07T12:39:48Z

What type of PR is this?
This PR adds functionality related to Subnet schema type, more details can be found in original issue #4784.

Add one of the following kinds:
/kind feature

What this PR does / why we need it:
As I mentioned above, this PR adds ability to configure preferred way for subnets division with priority to private as original behavior by default or public via PreferPublic.
For existing users nothing is changed because original behavior is not changed and set as default. But new parameter PreferPublic allows to use provider in more specific cases like with Google Agones where subnet division to with public subnets priority fits better.

Which issue(s) this PR fixes
Fixes #4784

Special notes for your reviewer:
My first PR to AWS provider =)

Checklist:

Release note:

New  `AWSCluster.spec.network.vpc.SubnetSchema` parameter  which allows to change preferred way of subnet division to public and private.

linux-foundation-easycla · 2024-05-07T12:39:54Z

The committers listed above are authorized under a signed CLA.

✅ login: krasoffski / name: Yury Krasouski (9534ec4)

k8s-ci-robot · 2024-05-07T12:39:57Z

Welcome @krasoffski!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-05-07T12:39:57Z

Hi @krasoffski. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

krasoffski · 2024-05-13T09:15:56Z

Hi, @dlipovetsky and @richardcase
Despite the fact, PR marked as size/XL the code change is small and simple. Rest of 90% of change is adding new unit tests.

krasoffski · 2024-06-06T06:57:58Z

Hi, @dlipovetsky and @richardcase
Please approve pipeline for this PR.

krasoffski · 2024-06-20T14:17:55Z

Hi, @dlipovetsky and @richardcase
Guys, please take a look.

krasoffski · 2024-07-03T09:57:16Z

Hi, @dlipovetsky and @richardcase
Could you please review this PR?
It is about 2 months since I created PR.

richardcase · 2024-07-17T10:22:38Z

Thank you for your patience @krasoffski. It's taken be a while to get back into things after a 6 week break away.

/ok-to-test

api/v1beta1/types.go

api/v1beta2/network_types.go

richardcase · 2024-07-17T10:28:20Z

/test ?

k8s-ci-robot · 2024-07-17T10:28:23Z

@richardcase: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build
/test pull-cluster-api-provider-aws-build-docker
/test pull-cluster-api-provider-aws-test
/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main
/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-blocking
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e-conformance
/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-gc
/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main
pull-cluster-api-provider-aws-build
pull-cluster-api-provider-aws-build-docker
pull-cluster-api-provider-aws-test
pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

richardcase · 2024-07-17T10:28:38Z

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

krasoffski · 2024-07-17T10:40:17Z

Thank you, @richardcase

I will take a look for test problems and come back.

krasoffski · 2024-07-17T15:30:22Z

/retest

krasoffski · 2024-07-18T12:01:38Z

Hi, @richardcase
I fixed comments and adjusted tests to the latest main.
Need confirmation from your side.

richardcase · 2024-07-18T13:25:45Z

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

krasoffski · 2024-07-18T14:04:45Z

/test pull-cluster-api-provider-aws-e2e

krasoffski · 2024-07-18T14:33:15Z

@richardcase
May I ask a question.

Do these jobs have timeouts or how long it usually takes to finish?

I am asking because I see that one of them running more than an hour.

Updated.
Found,
I see that pull-cluster-api-provider-aws-e2e passed yearterday, but today both of them failed due to timeout for suite precondition.

But it usually took about 2-3h in case everything is OK.

richardcase · 2024-07-18T15:34:37Z

Do these jobs have timeouts or how long it usually takes to finish?

Once the actual job starts running, there is a timeout (I forget what it is off the top of my head). And there are various timeouts in the tests (configured in the e2e config). There can be a delay from the Prow side before the tests are actually executed, this doesn't feed into the test timeout, though.

richardcase · 2024-07-18T15:37:51Z

Timeout is 4 hours: https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/Makefile#L163

richardcase · 2024-07-18T15:39:57Z

And the prow job has a 5 hour timeout: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-presubmits.yaml#L335

krasoffski · 2024-07-18T19:09:28Z

Thank you, @richardcase
It seems like tests are finished without issues.

richardcase · 2024-07-22T16:17:47Z

/milestone v2.6.0

alexander-demicev

thanks, the change looks good

/lgtm

richardcase · 2024-07-23T16:48:40Z

The e2e tests have passed.

This change looks good to me, thanks for this @krasoffski .

/approve

k8s-ci-robot · 2024-07-23T16:48:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

krasoffski · 2024-07-24T06:58:36Z

Thank you, Guys.
I am very appreciate this.

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 7, 2024

k8s-ci-robot added needs-priority cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 7, 2024

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2024

k8s-ci-robot requested review from dlipovetsky and richardcase May 7, 2024 12:40

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 7, 2024

krasoffski changed the title ~~Feature #4784: SubnetSchema support~~ Non-breaking feature: ✨ SubnetSchema support; Issue: 4784 May 7, 2024

krasoffski changed the title ~~Non-breaking feature: ✨ SubnetSchema support; Issue: 4784~~ ✨ SubnetSchema support; Issue: 4784 May 7, 2024

krasoffski changed the title ~~✨ SubnetSchema support; Issue: 4784~~ ✨ SubnetSchema support May 7, 2024

krasoffski force-pushed the feature/support_subnetscheme branch from 2320b77 to 4c74e82 Compare May 7, 2024 14:20

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2024

krasoffski force-pushed the feature/support_subnetscheme branch from 4c74e82 to 6b75e83 Compare June 20, 2024 14:16

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2024

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 17, 2024

richardcase reviewed Jul 17, 2024

View reviewed changes

api/v1beta1/types.go Outdated Show resolved Hide resolved

api/v1beta2/network_types.go Show resolved Hide resolved

krasoffski force-pushed the feature/support_subnetscheme branch from 6b75e83 to 2450236 Compare July 17, 2024 15:02

Feature kubernetes-sigs#4784: SubnetSchema support

9534ec4

krasoffski force-pushed the feature/support_subnetscheme branch from 2450236 to 9534ec4 Compare July 18, 2024 10:52

k8s-ci-robot added this to the v2.6.0 milestone Jul 22, 2024

alexander-demicev approved these changes Jul 23, 2024

View reviewed changes

k8s-ci-robot assigned alexander-demicev Jul 23, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024

k8s-ci-robot merged commit f23440c into kubernetes-sigs:main Jul 23, 2024
21 checks passed

krasoffski deleted the feature/support_subnetscheme branch July 24, 2024 06:58

krasoffski mentioned this pull request Sep 23, 2024

Security group rule "Node Port Services" can be more restrictive #3314

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ SubnetSchema support #4971

✨ SubnetSchema support #4971

krasoffski commented May 7, 2024 •

edited

Loading

linux-foundation-easycla bot commented May 7, 2024 •

edited

Loading

k8s-ci-robot commented May 7, 2024

k8s-ci-robot commented May 7, 2024

krasoffski commented May 13, 2024 •

edited

Loading

krasoffski commented Jun 6, 2024

krasoffski commented Jun 20, 2024

krasoffski commented Jul 3, 2024

richardcase commented Jul 17, 2024

richardcase commented Jul 17, 2024

k8s-ci-robot commented Jul 17, 2024

richardcase commented Jul 17, 2024

krasoffski commented Jul 17, 2024

krasoffski commented Jul 17, 2024

krasoffski commented Jul 18, 2024

richardcase commented Jul 18, 2024

krasoffski commented Jul 18, 2024

krasoffski commented Jul 18, 2024 •

edited

Loading

richardcase commented Jul 18, 2024

richardcase commented Jul 18, 2024

richardcase commented Jul 18, 2024

krasoffski commented Jul 18, 2024 •

edited

Loading

richardcase commented Jul 22, 2024

alexander-demicev left a comment

richardcase commented Jul 23, 2024

k8s-ci-robot commented Jul 23, 2024

krasoffski commented Jul 24, 2024

✨ SubnetSchema support #4971

✨ SubnetSchema support #4971

Conversation

krasoffski commented May 7, 2024 • edited Loading

linux-foundation-easycla bot commented May 7, 2024 • edited Loading

k8s-ci-robot commented May 7, 2024

k8s-ci-robot commented May 7, 2024

krasoffski commented May 13, 2024 • edited Loading

krasoffski commented Jun 6, 2024

krasoffski commented Jun 20, 2024

krasoffski commented Jul 3, 2024

richardcase commented Jul 17, 2024

richardcase commented Jul 17, 2024

k8s-ci-robot commented Jul 17, 2024

richardcase commented Jul 17, 2024

krasoffski commented Jul 17, 2024

krasoffski commented Jul 17, 2024

krasoffski commented Jul 18, 2024

richardcase commented Jul 18, 2024

krasoffski commented Jul 18, 2024

krasoffski commented Jul 18, 2024 • edited Loading

richardcase commented Jul 18, 2024

richardcase commented Jul 18, 2024

richardcase commented Jul 18, 2024

krasoffski commented Jul 18, 2024 • edited Loading

richardcase commented Jul 22, 2024

alexander-demicev left a comment

Choose a reason for hiding this comment

richardcase commented Jul 23, 2024

k8s-ci-robot commented Jul 23, 2024

krasoffski commented Jul 24, 2024

krasoffski commented May 7, 2024 •

edited

Loading

linux-foundation-easycla bot commented May 7, 2024 •

edited

Loading

krasoffski commented May 13, 2024 •

edited

Loading

krasoffski commented Jul 18, 2024 •

edited

Loading

krasoffski commented Jul 18, 2024 •

edited

Loading