Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 ROSA: Add support.md to the doc #4966

Merged
merged 1 commit into from
May 22, 2024

Conversation

serngawy
Copy link
Contributor

@serngawy serngawy commented Apr 29, 2024

What type of PR is this?
documentation

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 29, 2024
@k8s-ci-robot k8s-ci-robot requested review from Ankitasw and nrb April 29, 2024 21:08
@k8s-ci-robot k8s-ci-robot added needs-priority needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @serngawy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@serngawy
Copy link
Contributor Author

/cc @muraee

@k8s-ci-robot k8s-ci-robot requested a review from muraee April 30, 2024 15:06
NAME READY STATUS RESTARTS AGE
capa-controller-manager-77f5b946b-sddcg 1/1 Running 1 3d3h

$ kubectl logs -n capa-system capa-controller-manager-77f5b946b-sddcg &>> capa-controller-manager-logs.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why &>> ? this will append to end of file, so if the file had any previous content/logs it will be confusing to read.
> should be good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logs are only STDOUT, we don't need to redirect STDERR with &>
if kubectl logs throws the error, the user should see it and fix it before they can save the logs to a file.
please use only >

@@ -0,0 +1,17 @@
# Create issue for ROSA

When creating issue for ROSA-HCP cluster, include the logs for the capa-controller-manager and capi-controller-manager deployment pods. The logs can be saved to text file using the commands below. As well as, include the CRs that is used to create the ROSA ControlPlane, MachinePools and Cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When creating issue for ROSA-HCP cluster, include the logs for the capa-controller-manager and capi-controller-manager deployment pods. The logs can be saved to text file using the commands below. As well as, include the CRs that is used to create the ROSA ControlPlane, MachinePools and Cluster.
When creating issue for ROSA-HCP cluster, include the logs for the capa-controller-manager and capi-controller-manager deployment pods. The logs can be saved to text file using the commands below.
Please also include the yaml for all the resources used to create the ROSA cluster:
- `Cluster`
- `ROSAControlPlane`
- `MachinePool`
- `ROSAMachinePool`

we need to explicitly list the resource names we want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@serngawy serngawy force-pushed the support branch 2 times, most recently from 08d5b09 to b64a795 Compare May 3, 2024 18:23
@muraee
Copy link
Contributor

muraee commented May 6, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2024
@muraee
Copy link
Contributor

muraee commented May 6, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 6, 2024
@muraee
Copy link
Contributor

muraee commented May 6, 2024

/hold
@serngawy you also need to add the new section here:

- [External Auth Providers](./topics/rosa/external-auth.md)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2024
Signed-off-by: melserngawy <[email protected]>
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 6, 2024
@muraee
Copy link
Contributor

muraee commented May 7, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2024
@muraee
Copy link
Contributor

muraee commented May 7, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2024
@nrb
Copy link
Contributor

nrb commented May 8, 2024

/area provider/rosa

@k8s-ci-robot k8s-ci-robot added the area/provider/rosa Issues or PRs related to Red Hat ROSA provider label May 8, 2024
@nrb
Copy link
Contributor

nrb commented May 8, 2024

/assign @richardcase

or @Ankitasw for the approval.

@muraee
Copy link
Contributor

muraee commented May 13, 2024

cc @enxebre

@Ankitasw
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw, muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9c38444 into kubernetes-sigs:main May 22, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/rosa Issues or PRs related to Red Hat ROSA provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants