-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 ROSA: Add support.md to the doc #4966
Conversation
Hi @serngawy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @muraee |
docs/book/src/topics/rosa/support.md
Outdated
NAME READY STATUS RESTARTS AGE | ||
capa-controller-manager-77f5b946b-sddcg 1/1 Running 1 3d3h | ||
|
||
$ kubectl logs -n capa-system capa-controller-manager-77f5b946b-sddcg &>> capa-controller-manager-logs.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why &>>
? this will append to end of file, so if the file had any previous content/logs it will be confusing to read.
>
should be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logs are only STDOUT, we don't need to redirect STDERR with &>
if kubectl logs
throws the error, the user should see it and fix it before they can save the logs to a file.
please use only >
docs/book/src/topics/rosa/support.md
Outdated
@@ -0,0 +1,17 @@ | |||
# Create issue for ROSA | |||
|
|||
When creating issue for ROSA-HCP cluster, include the logs for the capa-controller-manager and capi-controller-manager deployment pods. The logs can be saved to text file using the commands below. As well as, include the CRs that is used to create the ROSA ControlPlane, MachinePools and Cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When creating issue for ROSA-HCP cluster, include the logs for the capa-controller-manager and capi-controller-manager deployment pods. The logs can be saved to text file using the commands below. As well as, include the CRs that is used to create the ROSA ControlPlane, MachinePools and Cluster. | |
When creating issue for ROSA-HCP cluster, include the logs for the capa-controller-manager and capi-controller-manager deployment pods. The logs can be saved to text file using the commands below. | |
Please also include the yaml for all the resources used to create the ROSA cluster: | |
- `Cluster` | |
- `ROSAControlPlane` | |
- `MachinePool` | |
- `ROSAMachinePool` |
we need to explicitly list the resource names we want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
08d5b09
to
b64a795
Compare
/ok-to-test |
/lgtm |
/hold
|
Signed-off-by: melserngawy <[email protected]>
/unhold |
/lgtm |
/area provider/rosa |
/assign @richardcase or @Ankitasw for the approval. |
cc @enxebre |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitasw, muraee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
documentation
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: