Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ ROSA: Support for External OIDC #4915

Merged
merged 2 commits into from
Apr 17, 2024
Merged

✨ ROSA: Support for External OIDC #4915

merged 2 commits into from
Apr 17, 2024

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Apr 9, 2024 •
edited
Loading

What type of PR is this?

Add one of the following kinds:
/kind feature

What this PR does / why we need it:
Adds support for external OIDC auth providers.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

ROSA: Support for External OIDC

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Apr 9, 2024
@k8s-ci-robot k8s-ci-robot requested review from damdo and nrb April 9, 2024 11:52
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 9, 2024
@muraee muraee changed the title ROSA: Support for External OIDC ✨ ROSA: Support for External OIDC Apr 9, 2024
@muraee muraee force-pushed the rosa-external-oidc branch 3 times, most recently from b81efd8 to 2ad7497 Compare April 9, 2024 13:03
@muraee
Copy link
Contributor Author

muraee commented Apr 9, 2024

/retest lint

@k8s-ci-robot
Copy link
Contributor

@muraee: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-build-docker
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-clusterclass
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks
  • /test pull-cluster-api-provider-aws-e2e-eks-gc
  • /test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-build-docker
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/retest lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@muraee
Copy link
Contributor Author

muraee commented Apr 9, 2024

/retest

@muraee muraee force-pushed the rosa-external-oidc branch from 2ad7497 to f92d3d7 Compare April 9, 2024 13:26
vincepri
vincepri approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@muraee muraee force-pushed the rosa-external-oidc branch from f92d3d7 to 824da9c Compare April 16, 2024 09:26
@nrb nrb mentioned this pull request Apr 17, 2024
Closed
@nrb
Copy link
Contributor

nrb commented Apr 17, 2024

/lgtm

Also assigned #4931 to @muraee to follow up on the documentation requested.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit a3368c7 into kubernetes-sigs:main Apr 17, 2024
18 checks passed
@nrb nrb mentioned this pull request Apr 23, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@nrb nrb nrb left review comments

@vincepri vincepri vincepri approved these changes

@damdo damdo Awaiting requested review from damdo

Assignees

@nrb nrb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@muraee @k8s-ci-robot @nrb @vincepri @stevekuznetsov