Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ ROSA: Add additionalTags API field to ROSAMachinePool #4869

Merged
merged 1 commit into from
Mar 14, 2024
Merged

✨ ROSA: Add additionalTags API field to ROSAMachinePool #4869

merged 1 commit into from
Mar 14, 2024

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Mar 14, 2024 •
edited
Loading

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

  • Add additionalTags API field to ROSAMachinePool
  • use the correct type metav1.Duration for NodeDrainGracePeriod field
  • fixed reconcileProviderIDList() listing terminated/stopped instances

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add `additionalTags` API field to ROSAMachinePool

@muraee
add additionalTags API fied to ROSAMachinePool
0e0e474 
- use the correct typemetav1.Duration for NodeDrainGracePeriod field
- fixed reconcileProviderIDList() listing terminated/stopped instances
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Mar 14, 2024
@k8s-ci-robot k8s-ci-robot requested review from fiunchinho and nrb March 14, 2024 12:34
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 14, 2024
@muraee
Copy link
Contributor Author

muraee commented Mar 14, 2024

cc @vincepri

vincepri
vincepri approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 73f4011 into kubernetes-sigs:main Mar 14, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

@nrb nrb Awaiting requested review from nrb

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muraee @k8s-ci-robot @vincepri