✨ Add flags for leaderElection timeouts

[nikParasyr]

What type of PR is this?
/kind feature

What this PR does / why we need it:

Add flags on manager to configure leaseDuration, renewDeadline and RetryPeriod for leader election. Set defaults based on cluster-api. These flags can be useful when the cluster runs on a relatively slow etcd.

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• includes emojis

Release note:

add flags to manager for leaderElection timeouts

[k8s-ci-robot]

Welcome @nikParasyr!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @nikParasyr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nikParasyr]

Not sure whether this should be categorized as ✨ or 🌱

[richardcase]

/ok-to-test

[nrb]

@nikParasyr I think ✨ is fine

[damdo]

Let's see if the new defaults work fine in an E2E

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

[nikParasyr]

/retest

[nrb]

/retest

[nikParasyr]

e2e passed but there were a couple of failed runs. Are they flaky or are the defaults not "so sane"?

[damdo]

@nikParasyr I don't see leader election churn in the CAPA controller logs for the failed E2E runs:

$ curl -sL https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/4845/pull-cluster-api-provider-aws-e2e/1765438070502461440/artifacts/clusters/bootstrap/controllers/capa-controller-manager/capa-controller-manager-6b8f8b488c-kwsbn/manager.log | grep leader

I0306 18:18:11.235696       1 leaderelection.go:250] attempting to acquire leader lease capa-system/controller-leader-elect-capa...
I0306 18:18:11.242312       1 leaderelection.go:260] successfully acquired lease capa-system/controller-leader-elect-capa
I0306 18:18:11.242916       1 recorder.go:104] "events: capa-controller-manager-6b8f8b488c-kwsbn_b073f072-da92-434f-a015-f43ddac83c9f became leader" type="Normal" object={"kind":"Lease","namespace":"capa-system","name":"controller-leader-elect-capa","uid":"fa6fe129-aeb8-4a9a-9c21-f89b48547ad9","apiVersion":"coordination.k8s.io/v1","resourceVersion":"1062"} reason="LeaderElection"

Plus I've seen those timeouts in other runs.
IMO unrelated. So PR should be good

/lgtm

[Ankitasw]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Ankitasw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment