Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Add new fields to ROSAControlPlane - additionalTags, etcdEncryption, endpointAccess #4844

Merged
merged 3 commits into from
Mar 6, 2024
Merged

✨Add new fields to ROSAControlPlane - additionalTags, etcdEncryption, endpointAccess #4844

merged 3 commits into from
Mar 6, 2024

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Mar 4, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:
Adding new API fields to ROSAControlPlane:

  • AdditionalTags,
  • EtcdEncryptionKMSArn
  • EndpointAccess

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add new fields to ROSAControlPlane - additionalTags, etcdEncryption, endpointAccess

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 4, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2024
@muraee muraee changed the title ✨Add missing Fields to ROSAControlPlane - additionalTags, etcdEncryption, private ✨Add new fields to ROSAControlPlane - additionalTags, etcdEncryption, private Mar 4, 2024
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2024
@muraee muraee force-pushed the rosacontrolplane-new-fields branch from 8780334 to 34867d1 Compare March 4, 2024 17:13
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 4, 2024
@muraee muraee changed the title ✨Add new fields to ROSAControlPlane - additionalTags, etcdEncryption, private ✨Add new fields to ROSAControlPlane - additionalTags, etcdEncryption, endpointAccess Mar 4, 2024
@muraee muraee mentioned this pull request Mar 5, 2024
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2024
xiangjingli and others added 2 commits March 6, 2024 12:48
@muraee muraee force-pushed the rosacontrolplane-new-fields branch from 34867d1 to 22ea09e Compare March 6, 2024 11:49
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2024
@muraee muraee force-pushed the rosacontrolplane-new-fields branch from 22ea09e to 87df892 Compare March 6, 2024 12:36
@muraee muraee mentioned this pull request Mar 6, 2024
Merged
5 tasks
vincepri
vincepri approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3a00c39 into kubernetes-sigs:main Mar 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muraee @k8s-ci-robot @vincepri @xiangjingli