🌱 Expose Cluster Control Plane ref through cluster scope #4822
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
vincepri
force-pushed
the
fixup-cluster-cp
branch
from
3336011 to
41797cb
Compare
| if cluster.Spec.ControlPlaneRef == nil { | ||
| // If the control plane ref is not set, return an empty object. | ||
| // Not having a control plane ref is valid given API contracts. | ||
| return &unstructured.Unstructured{}, nil |
There was a problem hiding this comment.
If we never use nil, do we need to return a pointer?
There was a problem hiding this comment.
The only downside about not having a pointer is the implicit when passing it around?
There was a problem hiding this comment.
I guess you meant implicit copy. Fair point.
vincepri
force-pushed
the
fixup-cluster-cp
branch
2 times, most recently
from
a820c7e to
118ec8a
Compare
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
fixup-cluster-cp
branch
from
118ec8a to
591e196
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @richardcase |
|
Fixes #4818 |
|
/test pull-cluster-api-provider-aws-e2e |
|
Timed out |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
What this PR does / why we need it:
/kind cleanup
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: