-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ ROSA machinePools support #4725
Conversation
Hi @muraee. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
0ee7377
to
59ec7b6
Compare
cc @vincepri this is the updated PR for machinePools |
/ok-to-test |
0a3f60d
to
3865e4b
Compare
/retest-required |
1 similar comment
/retest-required |
This commit introduces several improvements to the rosa control plane: - Add ROSAControlPlaneReadyCondition - Add helpers for ocmclient - Add WorkerRoleARN field to the API to satisfy latest ocm API requirements
- ensure RosaClusterName is valid using kubebuild validation - moved ocmClient to a seperate package and renamed to rosaClient - updated cluster-template-rosa.yaml - set ControlPlane.Status.Initialized - requeue ROSAControlPlane to poll cluster status until ready
This introduces basic support to create/delete ROSAMachinePools Lifecycle is captured in RosaMchinePoolReady condition - add cluster-template-rosa-machinepool.yaml
@muraee looks like unit tests are failing, could you fix it? |
8efcdbb
to
2a9ae4a
Compare
02a42ef
to
d6ad1bc
Compare
@muraee: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
- reset CommandLine flagSet before calling klog.InitFlags(nil) to avoid conflicts if an imported package already called it.
d6ad1bc
to
74a0ce7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind feature
supersedes #4686
What this PR does / why we need it:
Add initial support for ROSAMachinePools
What this PR does / why we need it:
This PR introduces basic support to create/delete ROSAMachinePoolsand a new cluster template to work with ROSAMachinePools.
It also add several improvements and fixes to the rosa control plane to get cluster creation functional:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4429, #4460
Special notes for your reviewer:
Checklist:
Release note: