Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Log full ARN in GC error messages #4709

Merged
merged 1 commit into from
Jan 8, 2024
Merged

✨ Log full ARN in GC error messages #4709

merged 1 commit into from
Jan 8, 2024

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Dec 21, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Log messages are currently unactionable because only an ID is given:

capa-controller-manager-6df7759674-hpchv manager 2023-12-21T10:17:16.005130350+01:00 	failed delete reconcile for gc service: deleting resources: deleting security group sg-084aa1bd14358af73: deleting security group: DependencyViolation: resource sg-084aa1bd14358af73 has a dependent object

At least the region is needed for humans to follow up. Else you'd have to loop through your AWS accounts and regions to find the ID, which is cumbersome.

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Log full ARN in GC error messages

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 21, 2023
@AndiDog
Copy link
Contributor Author

AndiDog commented Dec 21, 2023

/test pull-cluster-api-provider-aws-e2e-eks-gc

(and for unmanaged GC test, I'm not sure which command to use)

fiunchinho
fiunchinho approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@fiunchinho fiunchinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2023
@AndiDog
Copy link
Contributor Author

AndiDog commented Dec 21, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 21, 2023
vincepri
vincepri approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2024
@vincepri
Copy link
Member

vincepri commented Jan 2, 2024 •
edited
Loading

/hold

Feel free to unhold when ready

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 2, 2024
@AndiDog
Copy link
Contributor Author

AndiDog commented Jan 2, 2024

/retest

@AndiDog
Copy link
Contributor Author

AndiDog commented Jan 3, 2024

Rebased onto #4710 to try and fix the tests

/retest

@fiunchinho
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@AndiDog
Copy link
Contributor Author

AndiDog commented Jan 8, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 545b88d into kubernetes-sigs:main Jan 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@fiunchinho fiunchinho fiunchinho approved these changes

@AverageMarcus AverageMarcus Awaiting requested review from AverageMarcus

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

Assignees

@fiunchinho fiunchinho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndiDog @k8s-ci-robot @vincepri @fiunchinho