Skip to content

✨ feat: support setting HostnameType options for subnets and machines #4664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 29, 2024
Merged

✨ feat: support setting HostnameType options for subnets and machines #4664

merged 3 commits into from
Jan 29, 2024

Conversation

MaxFedotov
Copy link
Contributor

@MaxFedotov MaxFedotov commented Nov 28, 2023 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add support for setting HostnameType options for subnets and machines

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4653

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Support setting HostnameType options for subnets and machines

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 28, 2023
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 28, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @MaxFedotov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaxFedotov
Copy link
Contributor Author

@richardcase @Ankitasw @AverageMarcus Hi! Is there anything else I need to do to continue with this PR?

cnmcavoy
cnmcavoy suggested changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@cnmcavoy cnmcavoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 20, 2023
@MaxFedotov
Copy link
Contributor Author

/retest

@MaxFedotov
Copy link
Contributor Author

MaxFedotov commented Dec 22, 2023 •
edited
Loading

It seems like it is something weird with tests, i can run them locally without any errors

@Ankitasw
Copy link
Member

@MaxFedotov you might want to run make modules locally to fix this issue.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2024
@MaxFedotov MaxFedotov force-pushed the issues/4653 branch 2 times, most recently from eb12981 to 4667bff Compare January 18, 2024 15:03
@MaxFedotov
Copy link
Contributor Author

@Ankitasw @cnmcavoy i was able to fix all fuzzing tests, can you please take a look on PR

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2024
@Ankitasw
Copy link
Member

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@Ankitasw
Copy link
Member

/approve

cc @richardcase @vincepri @dlipovetsky for another look.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2024
vincepri
vincepri reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, totally optional, rest LGTM

vincepri
vincepri approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 836e77c into kubernetes-sigs:main Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnmcavoy cnmcavoy cnmcavoy requested changes

@vincepri vincepri vincepri approved these changes

@Ankitasw Ankitasw Awaiting requested review from Ankitasw

@AverageMarcus AverageMarcus Awaiting requested review from AverageMarcus

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support setting instance hostnames types
5 participants
@MaxFedotov @k8s-ci-robot @Ankitasw @vincepri @cnmcavoy