:sparkles: Add liveness/readiness probes by cpanato · Pull Request #1487 · kubernetes-sigs/cluster-api-provider-aws

cpanato · 2020-01-16T15:36:47Z

What this PR does / why we need it:
Add liveness and readiness probes

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1402

/kind feature
/milestone v0.5.0
/priority important-soon

k8s-ci-robot · 2020-01-16T15:36:49Z

@cpanato: You must be a member of the kubernetes-sigs/cluster-api-provider-aws-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Provider AWS Maintainers and have them propose you as an additional delegate for this responsibility.

Details

In response to this:

What this PR does / why we need it:
Add liveness and readiness probes

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1402

/kind feature
/milestone v0.5.0
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-01-16T15:36:57Z

Hi @cpanato. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cpanato · 2020-01-16T15:37:20Z

/assign @ncdc

ncdc

Thanks for this!

ncdc · 2020-01-16T15:47:47Z

/ok-to-test

ncdc · 2020-01-17T19:59:01Z

/lgtm
/assign @vincepri

ncdc · 2020-01-17T19:59:13Z

/hold

ncdc · 2020-01-17T19:59:23Z

Need to squash before we merge, but wait for Vince's review.

vincepri

One comment about the port

cpanato · 2020-01-22T18:09:56Z

@vincepri do you want to change the port to use 8080 or we can keep this one? i think in the example you post it is using that because it is a webapp application.
I was checking around and there is no standard port, at least i did not see in any place documented.

for example:

kube-dns uses 10054
coredns uses 8080
kubernetes-dashboard uses 8443
the old tiller from helm uses 44135

vincepri · 2020-01-24T17:38:35Z

I don't have super strong opinions, either way it should be ok, as long as we document these ports somewhere and have some sort of convention

cpanato · 2020-01-27T13:52:22Z

@vincepri @ncdc added a document to describe the ports used by CAPA, please let me know if that is not the right place.
PTAL

Signed-off-by: Carlos Panato <ctadeu@gmail.com>

cpanato · 2020-01-29T09:11:22Z

@ncdc @vincepri squashed. ptal
thanks!

vincepri

/hold cancel
/approve
/assign @ncdc

k8s-ci-robot · 2020-01-29T17:57:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ncdc · 2020-01-29T19:12:54Z

/lgtm

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 16, 2020

k8s-ci-robot requested review from sethp-nr and vincepri January 16, 2020 15:37

k8s-ci-robot assigned ncdc Jan 16, 2020

ncdc suggested changes Jan 16, 2020

View reviewed changes

Comment thread main.go Outdated

Comment thread main.go Outdated

Comment thread main.go Outdated

Comment thread main.go Outdated

Comment thread main.go Outdated

Comment thread config/manager/manager.yaml Outdated

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2020

ncdc added this to the v0.5.0 milestone Jan 16, 2020

k8s-ci-robot assigned vincepri Jan 17, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2020

ncdc approved these changes Jan 17, 2020

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2020

vincepri reviewed Jan 17, 2020

View reviewed changes

Comment thread config/manager/manager.yaml Outdated

cpanato mentioned this pull request Jan 20, 2020

✨ update metrics port #1489

Closed

ncdc mentioned this pull request Jan 22, 2020

Add liveness and readiness probes kubernetes-sigs/cluster-api#1855

Closed

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2020

cpanato mentioned this pull request Jan 27, 2020

✨ Add liveness/readiness probes kubernetes-sigs/cluster-api#2156

Merged

vincepri reviewed Jan 27, 2020

View reviewed changes

Comment thread docs/ports.md Outdated

Add liveness and readiness probes

0280646

Signed-off-by: Carlos Panato <ctadeu@gmail.com>

cpanato mentioned this pull request Jan 29, 2020

✨Add liveness and readiness probes kubernetes-sigs/cluster-api-provider-azure#374

Merged

vincepri approved these changes Jan 29, 2020

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2020

k8s-ci-robot merged commit 03dd538 into kubernetes-sigs:master Jan 29, 2020

cpanato deleted the GH-1402 branch January 29, 2020 19:30

This was referenced Feb 12, 2020

✨health: Add liveness and readiness probes kubernetes-sigs/cluster-api-provider-gcp#285

Merged

✨health: add liveness and readiness probes kubernetes-sigs/cluster-api-provider-openstack#508

Merged

cpanato mentioned this pull request Aug 25, 2020

✨ manager: add health probes kubernetes-retired/cluster-api-provider-packet#175

Merged

mainred mentioned this pull request Jul 26, 2022

chore: add charts for mcs controller manager Azure/fleet-networking#57

Merged

4 tasks

Conversation

cpanato commented Jan 16, 2020

Uh oh!

k8s-ci-robot commented Jan 16, 2020

Uh oh!

k8s-ci-robot commented Jan 16, 2020

Uh oh!

cpanato commented Jan 16, 2020

Uh oh!

ncdc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ncdc commented Jan 16, 2020

Uh oh!

ncdc commented Jan 17, 2020

Uh oh!

ncdc commented Jan 17, 2020

Uh oh!

ncdc commented Jan 17, 2020

Uh oh!

vincepri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cpanato commented Jan 22, 2020

Uh oh!

vincepri commented Jan 24, 2020

Uh oh!

cpanato commented Jan 27, 2020

Uh oh!

Uh oh!

cpanato commented Jan 29, 2020

Uh oh!

vincepri left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jan 29, 2020

Uh oh!

ncdc commented Jan 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants