🐛 Fix TestReconcileForCluster unit test #223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes the
TestReconcileForCluster
intermittent failure by not re-using a test artifact after it has conditions added to it. It's not ideal that we mutate some of these test resources, but I'm avoiding a larger refactor here to get the tests passing reliably.Which issue(s) this PR fixes:
Fixes #220
Thanks to @dmvolod for pointing out that
go test -count=2 ./controllers/helmchartproxy/...
makes this bug occur all the time. This allowed me to debug it. (Removingt.Parallel()
also triggers the failure.)