-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gnostic dependency with gnostic-models #625
Update gnostic dependency with gnostic-models #625
Conversation
Welcome @liangyuanpeng! |
Hi @liangyuanpeng. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
go.mod
Outdated
k8s.io/utils v0.0.0-20230115233650-391b47cb4029 | ||
sigs.k8s.io/controller-runtime v0.14.1 | ||
sigs.k8s.io/kustomize/kyaml v0.13.9 | ||
k8s.io/api v0.28.0-alpha.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, i just use v0.28.0-alpha.4 to fix it, and i think we need to waiting for a stable version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some api have changed, need update.
69a887f
to
b92c45e
Compare
b92c45e
to
583bbd8
Compare
@liangyuanpeng could you please revive this PR. We really need this merged to unblock the Flux upgrade to Kubernetes 1.28. Thank you! |
/ok-to-test |
/lgtm @seans3 PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I believe you can even update to the latest v0.28.4
(instead of v0.28.0
) if you prefer.
@karlkfi Is this update OK with you?
583bbd8
to
e01c587
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To match Kubernetes 1.28 these could also be bumped:
sigs.k8s.io/controller-runtime v0.16.3
sigs.k8s.io/kustomize/kyaml v0.15.0
sigs.k8s.io/yaml v1.4.0
For reference https://github.com/fluxcd/cli-utils/pull/1/files
e01c587
to
cb07b5f
Compare
@stefanprodan Thanks for remind. Sorry about duplicate lgtm. |
cb07b5f
to
9daef1f
Compare
- bump k8s.io packages to v0.28.4 - bump sigs.k8s.io/kustomize to v5.2.1 - bump sigs.k8s.io/controller-runtime to v0.16.3 - bump sigs.k8s.io/yaml to v1.4.0 - migrate from google/gnostic to google/gnostic-models Signed-off-by: Lan Liang <[email protected]>
9daef1f
to
6bdf5b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @liangyuanpeng
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liangyuanpeng, mortent, stefanprodan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related:
This PR changed:
k8s.io
packages to v0.28.4sigs.k8s.io/kustomize
to v5.2.1sigs.k8s.io/controller-runtime
to v0.16.3sigs.k8s.io/yaml
to v1.4.0google/gnostic
togoogle/gnostic-models