Increase golangci-lint timeout #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shaneutt
previously approved these changes
Nov 29, 2022
There was a problem hiding this comment.
See #27 (comment), but LGTM let's give this a try. Thank you!
|
@acald-creator can you please sign your commits? Also the docker build failure is unrelated to this change, we'll resolve that separately it doesn't need to hold this up. |
Signed-off-by: Antonette Caldwell <[email protected]>
acald-creator
force-pushed
the
fix-golangci-timeout
branch
from
9b237dd
to
2a4fd83
Compare
|
@shaneutt Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
golangci-linttimeout via GitHub Actions workflow.The default timeout is at 1 minute. Increasing the timeout should keep the workflow going until completed. May need to adjust as the code base gets larger.
Fixes #27
Signed-off-by: Antonette Caldwell [email protected]