Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: filter out Gateways before reconciliation #20

Merged
merged 3 commits into from
Nov 11, 2022
Merged

feat: filter out Gateways before reconciliation #20

merged 3 commits into from
Nov 11, 2022

Conversation

Rahul-D78
Copy link
Contributor

Filter out Gateways before reconciliation
Fixes: #17

@Rahul-D78
Copy link
Contributor Author

Hi @mlavacca please review

mlavacca
mlavacca requested changes Nov 11, 2022
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @Rahul-D78!

controllers/gateway_controller.go Outdated Show resolved Hide resolved
shaneutt
shaneutt requested changes Nov 11, 2022
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding this.

I have one comment about optimizing the predicate function, and then also the originally issue called for a unit test and then 👍

controllers/gateway_controller.go Outdated Show resolved Hide resolved
@Rahul-D78 Rahul-D78 requested review from shaneutt and removed request for mlavacca November 11, 2022 18:42
shaneutt
shaneutt approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

The original issue had requested a unit test for this, but I realized we don't have any prior art. I'm going to create a follow-up PR to add a unit test for this, and then from there we'll have an example we can use for future tests.

@shaneutt shaneutt merged commit 510b8aa into kubernetes-sigs:main Nov 11, 2022
@shaneutt shaneutt mentioned this pull request Nov 11, 2022
Closed
2 tasks
@Rahul-D78
Copy link
Contributor Author

Thanks a lot @shaneutt and @mlavacca 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlavacca mlavacca mlavacca requested changes

@shaneutt shaneutt shaneutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter out Gateways before reconciliation
3 participants
@Rahul-D78 @shaneutt @mlavacca