Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XDP redirect in kind #2

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Conversation

astoycos
Copy link
Member

@astoycos astoycos commented Nov 2, 2022

Try and ensure XDP redirect will work in KIND

This Updates the XDP program to rewrite:

  • Src Mac address
  • Dst Port

and allows us to configure if we want to run cksum
calculation on a per backend basis. It also fixes
the existing CKSUM calculation function to ignore
trailing bits.

Lastly We should be using the autogenerated bpf2go
map structs from bpf_*.go

For running in KIND make sure to turn ON GRO manually, and if using cksums (I wouldn't) turn off CKSUM offloading

Try and ensure XDP redirect will work in KIND

This Updates the XDP program to rewrite:
- Src Mac address
- Dst Port address

and allows us to configure if we want to run cksum
calculation on a per backend basis. It also fixes
the existing CKSUM calculation function to ignore
trailing bits.

Lastly We should be using the autogenerated bpf2go
map structs from `bpf_*.go`

Signed-off-by: Andrew Stoycos <[email protected]>
Signed-off-by: Andrew Stoycos <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Nov 2, 2022

CLA assistant check
All committers have signed the CLA.

@shaneutt shaneutt self-requested a review November 2, 2022 14:50
@shaneutt shaneutt self-assigned this Nov 2, 2022
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you Andrew. Just gonna merge this as-is for now since we're in early POC state. I'll do some testing to make sure things are working and then I'll wire up UDPRoute to it 👍

@shaneutt shaneutt merged commit e62bdda into kubernetes-sigs:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants