Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support VolumeExpansion in ONLINE scenario #123

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

ZeroMagic
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • Support VolumeExpansion in ONLINE scenario

  • Since the expanding operation is same, stands alone the function expandVolume()

Which issue(s) this PR fixes:

Fixes #43

Special notes for your reviewer:

Release note:

support VolumeExpansion in ONLINE scenario

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @ZeroMagic. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 16, 2019
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, ZeroMagic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 013935e into kubernetes-sigs:master Oct 16, 2019
levimm pushed a commit to levimm/azurefile-csi-driver that referenced this pull request Dec 25, 2019
fix: return empty when the specify source volume id does not exist
@ZeroMagic
Copy link
Member Author

ZeroMagic commented Feb 26, 2020

Taking a look at this PR again, the implementation could be wrong, may only need ControllerExpandVolume and for NodeExpandVolume, empty implementation is ok.
I filed a new issue to track this: #134

Yes, we don't need to resize the filesystem. I will set NodeExpandVolume to N/A.
/cc @andyzhangx

@ZeroMagic ZeroMagic deleted the online branch July 22, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support volume resize in k8s v1.14
3 participants