Skip to content

test pr to trigger CAPZ/windows tests#1171

Closed
marosset wants to merge 1 commit into
kubernetes-sigs:masterfrom
marosset:windows-tests
Closed

test pr to trigger CAPZ/windows tests#1171
marosset wants to merge 1 commit into
kubernetes-sigs:masterfrom
marosset:windows-tests

Conversation

@marosset
Copy link
Copy Markdown
Contributor

Signed-off-by: Mark Rossetti marosset@microsoft.com

This is an empty PR used to test changes we've made in CAPZ to enable azure-disk/azure-file tests for Windows

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 10, 2022
@marosset
Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-e2e-capz-azure-disk-windows

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 10, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andyzhangx
Copy link
Copy Markdown
Member

pull-kubernetes-e2e-capz-azure-disk-windows could not run since csi-proxy is not installed by default

@marosset
Copy link
Copy Markdown
Contributor Author

pull-kubernetes-e2e-capz-azure-disk-windows could not run since csi-proxy is not installed by default

We now run a daemonset which runs csi-proxy in a host-process container by default for windows nodes (for containerd clusters).
See kubernetes-sigs/cluster-api-provider-azure#2012

The logs for the job show that csi-proxy pod running on each Windows node:
https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_azuredisk-csi-driver/1171/pull-kubernetes-e2e-capz-azure-disk-windows/1491905459869716480/artifacts/workload-cluster/capz-sb95-g6mv6/kube-system_csi-proxy-45tjh_70d40b9d-e31f-4a87-8d94-3a9219cf44f9/csi-proxy/0.log

@andyzhangx
Copy link
Copy Markdown
Member

/test pull-kubernetes-e2e-capz-azure-disk
/test pull-kubernetes-e2e-capz-azure-disk-windows

@andyzhangx
Copy link
Copy Markdown
Member

/test pull-kubernetes-e2e-capz-azure-disk

1 similar comment
@andyzhangx
Copy link
Copy Markdown
Member

/test pull-kubernetes-e2e-capz-azure-disk

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@marosset: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-capz-azure-disk aa95a7e link false /test pull-kubernetes-e2e-capz-azure-disk

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@marosset
Copy link
Copy Markdown
Contributor Author

marosset commented Mar 7, 2022

/close
#1201 replaces this.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@marosset: Closed this PR.

Details

In response to this:

/close
#1201 replaces this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants