feat: switch back to csi-proxy v1beta interface on Windows#1034
Merged
andyzhangx merged 1 commit intoSep 30, 2021
Conversation
k8s-ci-robot
added
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
the
approved
andyzhangx
force-pushed
the
v1beta-intreface-win
branch
from
4be9f85 to
bcc1704
Compare
k8s-ci-robot
added
size/M
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
feat: switch back to csi-proxy v1beta interface on Windows due to breaking change
Before k8s 1.22, all default windows disk type is MBR, and
TypeofGet-Partitionfor MBR disk isIFS, PR(kubernetes-csi/csi-proxy#145) brings the breaking change. This PR switch back to csi-proxy v1beta interface on Windows until the new release(csi-proxy v1.1.0) with the fix is released.Which issue(s) this PR fixes:
Fixes Azure/AKS#2568
Requirements:
Special notes for your reviewer:
/hold
Release note: