Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marking node as unsuitable for traffic once ToBeDeletedByClusterAutoscaler taint is observed on it #1609

Closed
atulaggarwal opened this issue Nov 4, 2020 · 3 comments
Closed

Marking node as unsuitable for traffic once ToBeDeletedByClusterAutoscaler taint is observed on it #1609

atulaggarwal opened this issue Nov 4, 2020 · 3 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@atulaggarwal
Copy link
Contributor

Currently cluster autoscaler (https://github.com/kubernetes/autoscaler/) adds taint ToBeDeletedByClusterAutoscaler before removing the node from ASG.
Current aws-load-balancer-controller listens for Cordon nodes only but does not listen for this specific taint. Due to this it causes 5xx during scale down event (Issue - kubernetes/autoscaler#1907).
This is already present in GCE Ingress (kubernetes/ingress-gce#792) and hence suggesting same should be added to AWS Load balancer too.

(I will be raising a PR for this issue soon)
@atulaggarwal atulaggarwal mentioned this issue Nov 25, 2020
Merged
@atulaggarwal atulaggarwal changed the title [v1] Marking node as unsuitable for traffic once ToBeDeletedByClusterAutoscaler taint is observed on it Marking node as unsuitable for traffic once ToBeDeletedByClusterAutoscaler taint is observed on it Nov 25, 2020
@atulaggarwal
Copy link
Contributor Author

As per the comments, raised the PR for v2 version of ALB Controller. Closed the previous PR and opened new one.

M00nF1sh added a commit that referenced this issue Jan 1, 2021
@atulaggarwal @M00nF1sh
Issue #1609 - Handling Cluster AutoScaler Taint to determine the heal…
e3f990a 
…thiness of node (#1688)

* Issue #1609. Checking for taint ToBeDeletedByClusterAutoscaler while checking if node is suitable to handle traffic.

* Changes as per the PR comments.

* remove unschedulable from LB node pool critera

Co-authored-by: M00nF1sh <[email protected]>
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 23, 2021
@atulaggarwal
Copy link
Contributor Author

PR has been merged. Closing the issue.

Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this issue Nov 9, 2023
@atulaggarwal @M00nF1sh @Timothy-Dougherty
Issue kubernetes-sigs#1609 - Handling Cluster AutoScaler Taint to det…
ceaa524 
…ermine the healthiness of node (kubernetes-sigs#1688)

* Issue kubernetes-sigs#1609. Checking for taint ToBeDeletedByClusterAutoscaler while checking if node is suitable to handle traffic.

* Changes as per the PR comments.

* remove unschedulable from LB node pool critera

Co-authored-by: M00nF1sh <[email protected]>
@kahirokunn kahirokunn mentioned this issue Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@k8s-ci-robot @atulaggarwal @fejta-bot