Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build to not produce incomplete binaries #59

Merged
merged 1 commit into from
Apr 9, 2018

Conversation

mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Mar 19, 2018

Resolves #48

This is manually verified to work by running:

$ dist/darwin_amd64/heptio-authenticator-aws init --cluster-id foo
INFO[2018-03-19T12:09:59+09:00] generated a new private key and certificate   certBytes=811 keyBytes=1192
INFO[2018-03-19T12:09:59+09:00] saving new key and certificate                certPath=cert.pem keyPath=key.pem
INFO[2018-03-19T12:09:59+09:00] loaded existing keypair                       certPath=cert.pem keyPath=key.pem
INFO[2018-03-19T12:09:59+09:00] writing webhook kubeconfig file               kubeconfigPath=heptio-authenticator-aws.kubeconfig
INFO[2018-03-19T12:09:59+09:00] copy cert.pem to /var/heptio-authenticator-aws/cert.pem on kubernetes master node(s)
INFO[2018-03-19T12:09:59+09:00] copy key.pem to /var/heptio-authenticator-aws/key.pem on kubernetes master node(s)
INFO[2018-03-19T12:09:59+09:00] copy heptio-authenticator-aws.kubeconfig to /etc/kubernetes/heptio-authenticator-aws/kubeconfig.yaml on kubernetes master node(s)
INFO[2018-03-19T12:09:59+09:00] configure your apiserver with `--authentication-token-webhook-config-file=/etc/kubernetes/heptio-authenticator-aws/kubeconfig.yaml` to enable authentication with heptio-authenticator-aws

@mumoshu mumoshu force-pushed the fix-incomplete-binary branch from eb0810d to bda6493 Compare March 19, 2018 05:16
@nckturner
Copy link
Contributor

Sorry it took so long for me to get to this! LGTM, just tested it.

@nckturner nckturner merged commit d282f87 into kubernetes-sigs:master Apr 9, 2018
@mumoshu
Copy link
Contributor Author

mumoshu commented Apr 9, 2018

@nckturner Thanks for taking your time 👍

@mumoshu mumoshu deleted the fix-incomplete-binary branch April 9, 2018 06:03
joanayma pushed a commit to joanayma/aws-iam-authenticator that referenced this pull request Aug 11, 2021
Updating heptio-authenticator-aws to aws-iam-authenticator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants