Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare v0.5.11 release #510

Merged
merged 13 commits into from
Nov 8, 2022
Merged

prepare v0.5.11 release #510

merged 13 commits into from
Nov 8, 2022

Conversation

nnmin-aws
Copy link
Contributor

@nnmin-aws nnmin-aws commented Nov 8, 2022 •
edited
Loading

This PR cherry picks PR merged on master branch to branch release-0.5.

It picked up the following pr in summary:

  1. e2e test with kops
  2. print version and commitId on startup
  3. new dynamicfile backend mode
  4. e2e test with kind

richzli and others added 13 commits November 7, 2022 21:11
@richzli @nnmin-aws
Added ConfiguredInitDirectories featuregate for init command
73a09f0 
Allow init to respect the state directory and kubeconfig paths
by toggling a feature gate

Co-authored-by:
- Daniel Seymour <[email protected]>
- Nicholas Turner <[email protected]>
@richzli @nnmin-aws
Basic E2E testing for authenticator
c6a2c08
@richzli @nnmin-aws
Add e2e recipe to Makefile
af5db65
@richzli @nnmin-aws
Non-blocking E2E tests
8684614
@richzli @nnmin-aws
Working E2E tests in prow
bdfc6d2
@nnmin-aws
Minor fix on the script to solve permission denied issue when run mak…
5d89d57 
…e start-dev
@nnmin-aws
Add new backend mode DYNAMICFILE
45777aa
@nckturner @nnmin-aws
Print version on startup
da8510b
@nckturner @nnmin-aws
Print CommitID too on startup
bcdcb3a 
- Print commit id in addition to version
- Only log for specific commands starting with init and server
@nnmin-aws
add end to end test for dynamicfile backend
14e71c2 
to run it:

make start-dev-dynamicfile
@tingrui-AWS-EKS-auth @nnmin-aws
update Dockerfile to use Golang as builder
ce87d8a
@nnmin-aws
remove dependency from PR kubernetes-sigs#416
1acb533
@nnmin-aws
Add end to end test for mountfile mode in kind
052daeb 
Update Makefile to support run e2e from either kind or kops.

make e2e RUNNER=kind #to run e2e on kind
make e2e RUNNER=kops #to run e2e on kops
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 8, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @nnmin-aws. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 8, 2022
@nckturner
Copy link
Contributor

Why is 1acb533 included?

nckturner
nckturner reviewed Nov 8, 2022
View reviewed changes
hack/start-dev-env-dynamicfile.sh
@@ -56,6 +56,7 @@ write_kind_config
create_kind_cluster
certificate_authority_data="$(extract_certificate_authority_data)"
write_kubectl_kubeconfig
echo "start end to end testing for mountfile mode"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only nit is this is called "start dev env" but its used to run e2e tests. Do you use this for both? I'd like to separate them and have e2e tests run from the e2e script and dev envs set up from the dev script, and just have options to choose between dynamic file or other backends. We can do that in a future improvement if you'd like.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nckturner! this is a good point. I will create a separate PR after this cherry-pick to move the e2e out.

@nnmin-aws
Copy link
Contributor Author

Why is 1acb533 included?

thanks @nckturner for the comments.
1acb533 is included because dynamicfile mode originally invoked two methods (validate) which belong to PR #416, this commit replaced the invocation of two methods.

@nckturner
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 8, 2022
@nckturner
Copy link
Contributor

For PR description, please make any changes if I've made a mistake:

73a09f0, c6a2c08, af5db65, 8684614, bdfc6d2: These commits are included to enable e2e testing on this branch.

5d89d57: Minor bugfix related to dev env file permissions.

45777aa: This feature is being cherry picked to release-0.5 to support a feature launch in EKS--some platform versions use the release-0.5 branch and we need feature support in those versions.

da8510b, bcdcb3a: Print version on startup to make debugging easier.

14e71c2: E2E test for 45777aa.

ce87d8a: Update go version used to build.

1acb533: Remove dependency of 45777aa on the SSO PR.

052daeb: Add makefile target for new e2e test.

@nckturner
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2022
@nckturner
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner, nnmin-aws

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit e2f85e0 into kubernetes-sigs:release-0.5 Nov 8, 2022
@nnmin-aws nnmin-aws deleted the nnmin-release2 branch January 17, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nckturner nckturner nckturner left review comments

@jyotimahapatra jyotimahapatra Awaiting requested review from jyotimahapatra

@micahhausler micahhausler Awaiting requested review from micahhausler

Assignees

@nckturner nckturner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nnmin-aws @k8s-ci-robot @nckturner @richzli @tingrui-AWS-EKS-auth