Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump aws sdk go to v1.44.107 #491

Merged
merged 3 commits into from
Sep 30, 2022
Merged

Bump aws sdk go to v1.44.107 #491

merged 3 commits into from
Sep 30, 2022

Conversation

jngo2
Copy link
Contributor

@jngo2 jngo2 commented Sep 27, 2022

Bump aws go sdk to latest

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 27, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @jngo2. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 27, 2022
@jyotimahapatra
Copy link
Contributor

@nckturner i was wondering if we need the vendoring ? We can just update the go.mod and go.sum when the dependencies change. wdyt?

@nckturner
Copy link
Contributor

i was wondering if we need the vendoring ?

@jyotimahapatra The vendoring was removed recently. What are you referring to?

nckturner
nckturner reviewed Sep 28, 2022
View reviewed changes
go.mod Show resolved Hide resolved
@jyotimahapatra
Copy link
Contributor

i was wondering if we need the vendoring ?

@jyotimahapatra The vendoring was removed recently. What are you referring to?

Yeah..i feel i saw vendored files :( and asked the question

@jyotimahapatra
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2022
@jyotimahapatra
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 29, 2022
@jyotimahapatra
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2022
@jyotimahapatra
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jngo2, jyotimahapatra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit f15f0fd into kubernetes-sigs:master Sep 30, 2022
This was referenced Sep 30, 2022
Closed
Merged
nckturner pushed a commit that referenced this pull request Oct 7, 2022
@jngo2
Automated cherry pick of #491: Bump aws sdk go to v1.44.107 (#493)
3e81377 
* Bump aws sdk go to v1.44.107

* Replace tabs with spaces in go.mod

* Update go.mod and go.sum for tests/integrations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nckturner nckturner nckturner left review comments

@jyotimahapatra jyotimahapatra jyotimahapatra left review comments

@justinsb justinsb Awaiting requested review from justinsb

@micahhausler micahhausler Awaiting requested review from micahhausler

Assignees

@jyotimahapatra jyotimahapatra

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jngo2 @k8s-ci-robot @jyotimahapatra @nckturner