Skip to content

Remove old TravisCI config file#978

Closed
asherf wants to merge 4 commits into
kubernetes-sigs:masterfrom
asherf:leftovers
Closed

Remove old TravisCI config file#978
asherf wants to merge 4 commits into
kubernetes-sigs:masterfrom
asherf:leftovers

Conversation

@asherf
Copy link
Copy Markdown
Contributor

@asherf asherf commented Mar 31, 2023

As far as I can tell, TravisCI is no longer used in this repo.

Feel free to close this PR if travisCI is still being used and this file should remain

As far as I can tell, TravisCI is no longer used in this repo.

Signed-off-by: Asher Foa <1268088+asherf@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 31, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @asherf!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 31, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @asherf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 31, 2023
@asherf
Copy link
Copy Markdown
Contributor Author

asherf commented May 2, 2023

@mskanth972 @Ashley-wenyizha ping

@kuba-wolf
Copy link
Copy Markdown

Note: FSx for Lustre did this as well in this PR: kubernetes-sigs/aws-fsx-csi-driver#302. @asherf you should also remove the test coverage check in the readme: https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/docs/README.md?plain=1#L1

@kuba-wolf
Copy link
Copy Markdown

@asherf Sorry for taking so long to come back to this, can you rebase those 3 commits into one? Once that's done I can help this get merged.
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asherf
Once this PR has been reviewed and has the lgtm label, please assign nckturner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@asherf
Copy link
Copy Markdown
Contributor Author

asherf commented Sep 12, 2023

@asherf Sorry for taking so long to come back to this, can you rebase those 3 commits into one? Once that's done I can help this get merged. /ok-to-test

done.

@kuba-wolf
Copy link
Copy Markdown

Can you squash the 4 commits into one?

@asherf
Copy link
Copy Markdown
Contributor Author

asherf commented Sep 13, 2023

Can you squash the 4 commits into one?

you can do a squash commit in GH when you land the PR.
I don't have this branch locally on my computer anymore.
Screenshot 2023-09-13 at 10 47 20 AM

@kuba-wolf
Copy link
Copy Markdown

kuba-wolf commented Sep 13, 2023

afaik the preferred approach for reviews is to have the cli bot perform the merge, part of the reason being that an admin for the repo is needed to merge the pr in this way. I hope you don't mind, I rebased your commit for you and opened a new PR: #1129

@asherf asherf closed this Sep 19, 2023
@asherf asherf deleted the leftovers branch September 19, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants