Add maxInflightMountCalls and volumeAttachLimit args by DavidXU12345 · Pull Request #1706 · kubernetes-sigs/aws-efs-csi-driver

DavidXU12345 · 2025-09-16T17:16:57Z

Is this a bug fix or adding new feature?
Adding new feature.

What is this PR about? / Why do we need it?
Add maxInflightMountCalls and volumeAttachLimit args. We need them to prevent OOM killed issue for efs-plugin container since it takes 30MiB for mounting operation and 12MiB for each EFS volume due to efs-proxy process.

What testing is done?

Unit tests
e2e test
Manually deploy csi driver with this change locally to verify OOM issue can be solved with maxInflightMountCalls and volumeAttachLimit being set

k8s-ci-robot · 2025-09-16T17:17:07Z

Hi @DavidXU12345. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

DavidXU12345 · 2025-09-16T17:26:20Z

 		klog.Fatalln(err)
 	}
-	drv := driver.NewDriver(*endpoint, etcAmazonEfs, *efsUtilsStaticFilesPath, *tags, *volMetricsOptIn, *volMetricsRefreshPeriod, *volMetricsFsRateLimit, *deleteAccessPointRootDir, *adaptiveRetryMode)
+	drv := driver.NewDriver(*endpoint, etcAmazonEfs, *efsUtilsStaticFilesPath, *tags, *volMetricsOptIn, *volMetricsRefreshPeriod, *volMetricsFsRateLimit, *deleteAccessPointRootDir, *adaptiveRetryMode, *maxInflightMountCallsOptIn, *maxInflightMountCalls, *volumeAttachLimitOptIn, *volumeAttachLimit)


We should probably add all options into its own type (similar as EBS CSI driver) so that we can pass option around rather than passing each value into NewDriver for example. We can also encapsulate validation logic in option as well (e.g. check if maxInflightMountCallsOptIn is true, maxInflightMountCalls has to be a positive value).

I may consider to do the refactoring in next PR since the size of this PR is already very large.

dankova22 · 2025-09-18T21:13:25Z

-		tags              = flag.String("tags", "", "Space separated key:value pairs which will be added as tags for EFS resources. For example, 'environment:prod region:us-east-1'")
+		adaptiveRetryMode          = flag.Bool("adaptive-retry-mode", true, "Opt out to use standard sdk retry configuration. By default, adaptive retry mode will be used to more heavily client side rate limit EFS API requests.")
+		tags                       = flag.String("tags", "", "Space separated key:value pairs which will be added as tags for EFS resources. For example, 'environment:prod region:us-east-1'")
+		maxInflightMountCallsOptIn = flag.Bool("max-inflight-mount-calls-opt-in", false, "Opt in to use max inflight mount calls limit.")


Do you think we could simplify this by just creating one flag for each? If no is maxInflightCalls or volumeLimit is provided we just use current behavior (not limited at all)?

I prefer to keep the OptIn flag primarily for future-proofing. If we later implement default calculations for maxInflightCalls or volumeLimit, users could set OptIn=true without specifying values for parameters like maxInflightMountCalls.

While we could remove the OptIn feature gate later if we decide not to provide default calculations, adding it back would be more disruptive. From a user perspective, without OptIn=true, a configuration with maxInflightMountCalls=10 would be ignored, breaking backward compatibility.

dankova22 · 2025-10-02T14:31:09Z

/lgtm
/approve

dankova22 · 2025-10-02T14:31:28Z

/ok-to-test

dankova22 · 2025-10-02T14:58:23Z

/retest

1. maxInflightMountCalls with OptIn arg In order to use maxInflightMountCalls, user has to set maxInflightMountCallsOptIn to true and set a positive value for maxInflightMountCalls. 2. volumeAttachLimit with OptIn arg To use volumeAttachLimit, user has to set volumeAttachLimitOptIn to be true and set volumeAttachLimit to a positive value.

dankova22 · 2025-10-03T14:59:05Z

/lgtm
/approve

k8s-ci-robot · 2025-10-03T14:59:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dankova22, DavidXU12345

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dankova22]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested review from mskanth972 and nckturner September 16, 2025 17:17

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 16, 2025

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 16, 2025

DavidXU12345 force-pushed the concurrency-control branch from 3eb7f6a to 2f0bbed Compare September 16, 2025 17:17

DavidXU12345 commented Sep 16, 2025

View reviewed changes

DavidXU12345 force-pushed the concurrency-control branch 3 times, most recently from 60029aa to 0fe78c3 Compare September 17, 2025 20:41

dankova22 reviewed Sep 19, 2025

View reviewed changes

DavidXU12345 force-pushed the concurrency-control branch from 0fe78c3 to 7de4bf0 Compare September 19, 2025 15:38

wangnyue reviewed Sep 22, 2025

View reviewed changes

Comment thread cmd/main.go

wangnyue reviewed Sep 22, 2025

View reviewed changes

Comment thread pkg/driver/driver.go Outdated

wangnyue reviewed Sep 22, 2025

View reviewed changes

Comment thread pkg/driver/inflight_checker.go Outdated

DavidXU12345 force-pushed the concurrency-control branch from 7de4bf0 to 943e17b Compare September 23, 2025 22:21

DavidXU12345 mentioned this pull request Sep 25, 2025

REQUEST: New membership for DavidXU12345 kubernetes/org#5865

Closed

11 tasks

k8s-ci-robot assigned dankova22 Oct 2, 2025

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 2, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 2, 2025

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2025

DavidXU12345 force-pushed the concurrency-control branch 3 times, most recently from c20bee8 to be64472 Compare October 2, 2025 18:47

DavidXU12345 force-pushed the concurrency-control branch from be64472 to 4dfcfa1 Compare October 2, 2025 21:19

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2025

dankova22 merged commit 68eb57d into kubernetes-sigs:master Oct 3, 2025
5 of 6 checks passed

dfajmon mentioned this pull request Nov 3, 2025

STOR-2598: Rebase to upstream v2.1.11 for OCP 4.21 openshift/aws-efs-csi-driver#106

Merged

dfajmon mentioned this pull request Feb 18, 2026

[DO NOT MERGE] STOR-2912: Rebase to upstream v2.3.0 for OCP 4.23 openshift/aws-efs-csi-driver#109

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add maxInflightMountCalls and volumeAttachLimit args#1706

Add maxInflightMountCalls and volumeAttachLimit args#1706
dankova22 merged 1 commit into
kubernetes-sigs:masterfrom
DavidXU12345:concurrency-control

DavidXU12345 commented Sep 16, 2025

Uh oh!

k8s-ci-robot commented Sep 16, 2025

Uh oh!

DavidXU12345 Sep 16, 2025 •

edited

Loading

Uh oh!

dankova22 Sep 18, 2025

Uh oh!

DavidXU12345 Sep 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dankova22 commented Oct 2, 2025

Uh oh!

dankova22 commented Oct 2, 2025

Uh oh!

dankova22 commented Oct 2, 2025

Uh oh!

dankova22 commented Oct 3, 2025

Uh oh!

Uh oh!

k8s-ci-robot commented Oct 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

DavidXU12345 commented Sep 16, 2025

Uh oh!

k8s-ci-robot commented Sep 16, 2025

Uh oh!

DavidXU12345 Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dankova22 Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

DavidXU12345 Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dankova22 commented Oct 2, 2025

Uh oh!

dankova22 commented Oct 2, 2025

Uh oh!

dankova22 commented Oct 2, 2025

Uh oh!

dankova22 commented Oct 3, 2025

Uh oh!

Uh oh!

k8s-ci-robot commented Oct 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DavidXU12345 Sep 16, 2025 •

edited

Loading