Allow : in Tags with Escape Character#1693
Conversation
|
|
|
Welcome @samuhale! |
|
Hi @samuhale. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
b0c53e9 to
5b3cef4
Compare
|
Ran gofmt on files I changed, only changes are whitespace and removing an unneeded semicolon |
5b3cef4 to
3b9591a
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dankova22, samuhale The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Adding support for
:in tag names using\as an escape characterWhat is this PR about? / Why do we need it?
Issue #1689
What testing is done?
Added additional check to ensure tag parsing works with the escape character and without it, ran them with
make test