Skip to content

Update dependencies and fix go.sum#1663

Merged
dankova22 merged 3 commits into
kubernetes-sigs:masterfrom
anthotse:issue1659
Jul 9, 2025
Merged

Update dependencies and fix go.sum#1663
dankova22 merged 3 commits into
kubernetes-sigs:masterfrom
anthotse:issue1659

Conversation

@anthotse
Copy link
Copy Markdown
Contributor

@anthotse anthotse commented Jul 8, 2025

Change summary:

  1. Address issue 1659: Invalid golang.org/x/net checksum and kubernetes
    version. go.sum was regenerated with go mod tidy, vendored
    dependencies where updated with go mod vendor
  2. Upgrade k8s modules to 33.2, and clean go.mod replace directive
  3. Update mock_k3s_client.go using update-gomock script output
  4. Add ControllerModifyVolume implementation for ControllerServer Interface

Is this a bug fix or adding new feature?

Upgrade dependencies + fix for #1659

What is this PR about? / Why do we need it?

What testing is done?

anthotse added 2 commits July 8, 2025 17:06
Change summary:
1) Address issue 1659: Invalid golang.org/x/net checksum and kubernetes
version. go.sum was regenerated with `go mod tidy`, vendored
dependencies where updated with `go mod vendor`
2) Upgrade k8s modules to 33.2, and clean go.mod replace directive
3) Update mock_k3s_client.go using update-gomock script output
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 8, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @anthotse. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from d-nishi and dankova22 July 8, 2025 21:38
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anthotse
Once this PR has been reviewed and has the lgtm label, please assign d-nishi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 8, 2025
@dankova22
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 8, 2025
@dankova22
Copy link
Copy Markdown
Contributor

/retest

@anthotse
Copy link
Copy Markdown
Contributor Author

anthotse commented Jul 9, 2025

/retest

1 similar comment
@anthotse
Copy link
Copy Markdown
Contributor Author

anthotse commented Jul 9, 2025

/retest

@dankova22
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2025
@dankova22 dankova22 merged commit fc1eabe into kubernetes-sigs:master Jul 9, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants