Discover EFS FileSystemId instead of specifying it in storage class#1492
Discover EFS FileSystemId instead of specifying it in storage class#1492avanish23 wants to merge 4 commits into
Conversation
|
Hi @avanish23. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
discovering efs with tags support add new mocks added mount_utils interface to the MockMounter discovering efs with single AWS call
b445adf to
65af3c8
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: avanish23 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thank you @avanish23 for the pr to close my issue. Who is the right person to review this pr? |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What is this PR about? / Why do we need it?
This PR introduces the feature of discovering EFS FileSystemId instead of having to specify it in the SC parameters.
The way to use this feature is to create a storage class where the parameters have a new field
fileSystemDiscovery.Currently, it takes 2 fields
creationTokenandtagsboth being optional.creationToken is a string that takes the creation token of the EFS to be discovered as input
tags is a map of strings
Sample Storage Class
Note:
|as it is a multi-line string inputWhat testing is done?
Unit tests added and current unit tests pass
Closes #1052