Skip to content

feat: enable metrics for csi-provisioner #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hichem-belhocine wants to merge 3 commits into from
Closed

feat: enable metrics for csi-provisioner #1378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71fa32c
feat: enable metrics for csi-provisioner
hichem-belhocine Jun 18, 2024
3b219f9
Merge branch 'master' into master
hichem-belhocine Feb 14, 2025
0a17b8d
Merge remote-tracking branch 'upstream/master'
hichem-belhocine Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions charts/aws-efs-csi-driver/templates/controller-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,15 +143,34 @@ spec:
{{- if hasKey .Values.controller "timeout" }}
- --timeout={{ .Values.controller.timeout }}
{{- end }}
{{- if hasKey .Values.controller "workerThreads" }}
- --worker-threads={{ .Values.controller.workerThreads }}
{{- end }}
{{- if hasKey .Values.controller "timeout" }}
- --timeout={{ .Values.controller.timeout }}
{{- end }}
{{- if .Values.controller.metrics.enabled }}
- --metrics-address=:{{ .Values.controller.metrics.port }}
- --metrics-path={{ .Values.controller.metrics.path }}
{{- end }}
{{- if .Values.sidecars.csiProvisioner.additionalArgs }}
{{- range .Values.sidecars.csiProvisioner.additionalArgs }}
- {{ . }}
{{- end }}
{{- end }}
env:
- name: ADDRESS
value: /var/lib/csi/sockets/pluginproxy/csi.sock
volumeMounts:
- name: socket-dir
mountPath: /var/lib/csi/sockets/pluginproxy/
{{- if .Values.controller.metrics.enabled }}
ports:
- name: metrics
containerPort: {{ .Values.controller.metrics.port }}
protocol: TCP
{{- end }}
{{- with .Values.sidecars.csiProvisioner.resources }}
{{- with default .Values.controller.resources .Values.sidecars.csiProvisioner.resources }}
resources: {{ toYaml . | nindent 12 }}
{{- end }}
Expand Down
6 changes: 6 additions & 0 deletions charts/aws-efs-csi-driver/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,12 @@ controller:
privileged: true
leaderElectionRenewDeadline: 10s
leaderElectionLeaseDuration: 15s
# Enable metrics for csi-provisioner
metrics:
enabled: false
port: 8080
path: /metrics

# Timeout for Create/DeleteVolume calls to Controller. We recommend increasing for high concurrency workloads
timeout: 15s
# Number of concurrent threads controller will handle at once.
Expand Down