Added checks to make sure delete-access-point should not delete entir… by mskanth972 · Pull Request #1201 · kubernetes-sigs/aws-efs-csi-driver

mskanth972 · 2023-11-29T04:19:02Z

…e EFS

Is this a bug fix or adding new feature?
This is a bug fix

What is this PR about? / Why do we need it?

Added checks to make sure delete-access-point should not delete entire EFS

What testing is done?

…e EFS

k8s-ci-robot · 2023-11-29T04:19:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mskanth972

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [mskanth972]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

the-technat · 2023-11-30T17:20:06Z

 			}

+			klog.V(2).Infof("Access point root directory : %s", accessPoint.AccessPointRootDir)
+			if accessPoint.AccessPointRootDir == "/" {


What happens when accessPoint.AccessPointRootDir is an empty string? (The field seems not mandatory when creating an AP, so could in rare cases be empty).

According to my understanding the efs-plugin mounts the entire filesystem in /var/lib/csi/pv/<fsap-id> and later calls os.RemoveAll(target, accessPoint.AccessPointRootDir). Now if accessPoint.AccessPointRootDir is empty, the left-over path for os.RemoveAll is /var/lib/csi/pv/<fsap-id> which represents the entire filesystem. I'm I right with that?

We pull AccessPointRootDir from an API call to the AWS EFS console API:

aws-efs-csi-driver/pkg/driver/controller.go

Line 374 in 8b78393

accessPoint, err := localCloud.DescribeAccessPoint(ctx, accessPointId)

The API layer has empty access point root dirs default to the root path, so an empty access point root dir shouldn't be possible.

But, I agree, we should validate our assumptions and add a check, just in case.

k8s-triage-robot · 2024-03-04T14:31:21Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-ci-robot · 2024-03-28T06:34:41Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-triage-robot · 2024-04-27T06:37:45Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

mkilchhofer · 2024-05-10T14:15:02Z

/remove-lifecycle rotten

k8s-triage-robot · 2024-08-08T14:26:46Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-09-07T15:14:28Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

mkilchhofer · 2024-09-11T20:47:10Z

/remove-lifecycle rotten

Xref:

--delete-access-point-root-dir=true might delete wrong dir #1085

k8s-triage-robot · 2024-12-10T21:24:01Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2025-01-09T21:57:05Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

mkilchhofer · 2025-01-10T07:14:45Z

/remove-lifecycle rotten

@dobsonj @mskanth972 is anything missing here or why did you not merge it?

k8s-triage-robot · 2025-04-10T07:55:32Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2025-05-10T08:51:20Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

mkilchhofer · 2025-05-10T22:17:23Z

/remove-lifecycle rotten

k8s-triage-robot · 2025-08-08T22:35:02Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

dankova22 · 2025-08-15T21:59:09Z

Addressed in #1592 and #1532

Added checks to make sure delete-access-point should not delete entir…

8b78393

…e EFS

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 29, 2023

k8s-ci-robot requested review from Ashley-wenyizha and leakingtapan November 29, 2023 04:19

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 29, 2023

the-technat reviewed Nov 30, 2023

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 4, 2024

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 27, 2024

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 10, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 7, 2024

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 11, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 10, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 9, 2025

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 10, 2025

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2025

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 10, 2025

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 10, 2025

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2025

dankova22 closed this Aug 15, 2025

This was referenced Sep 4, 2025

delete-access-point probably delete entire EFS when apRootPath == "/" #1695

Closed

Make sure delete-access-point should not delete entire EFS #1696

Closed

Conversation

mskanth972 commented Nov 29, 2023

Uh oh!

k8s-ci-robot commented Nov 29, 2023

Uh oh!

the-technat Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

RyanStan Dec 5, 2023

Choose a reason for hiding this comment

Uh oh!

k8s-triage-robot commented Mar 4, 2024

Uh oh!

k8s-ci-robot commented Mar 28, 2024

Uh oh!

k8s-triage-robot commented Apr 27, 2024

Uh oh!

mkilchhofer commented May 10, 2024

Uh oh!

k8s-triage-robot commented Aug 8, 2024

Uh oh!

k8s-triage-robot commented Sep 7, 2024

Uh oh!

mkilchhofer commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-triage-robot commented Dec 10, 2024

Uh oh!

k8s-triage-robot commented Jan 9, 2025

Uh oh!

mkilchhofer commented Jan 10, 2025

Uh oh!

k8s-triage-robot commented Apr 10, 2025

Uh oh!

k8s-triage-robot commented May 10, 2025

Uh oh!

mkilchhofer commented May 10, 2025

Uh oh!

k8s-triage-robot commented Aug 8, 2025

Uh oh!

dankova22 commented Aug 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mkilchhofer commented Sep 11, 2024 •

edited

Loading