Cherry-picking commits to release-1.7 branch#1142
Conversation
Adding subPathPattern allows us to support more use cases than before because
now users can specify a template they wish to be created when the access
point is created. This template matches the form of the nfs-subdir-provioner
which aids consistency. This defaults to /${.PV.name} to be in keeping with
current behaviour but allows much more flexibility.
This ensures we can control when we want directories created under dynamic provisioning to be unique and when we don't (poweruser mode)
This code is needed to allow listing of access points. This can be used by GID allocator to avoid assigning GIDs that might already be used.
Internal limit of EFS is 120 Access Points per Filesystem ID. There is no reason to check the entire GID range specified by user if we can't allocate those GIDs anyway. Considering the internal limit there is no need to track the GIDs using heap structure and we can always look up the next GID from the full range which won't exceed 120. Because the limit is relatively small this won't impact performance.
We added CSI_NODE_NAME as an environment variable to the Helm Chart's node Daemonset, but we forget to add it to our kustomize deploy files as well. This is required for users who have IMDS disabled on their cluster, and who install the driver using kustomize.
Signed-off-by: Asher Foa <1268088+asherf@users.noreply.github.com> PR feedback
I notice the name for `ensureUniqueDirectory` is wrong in the README, its correct at the example, but wrong here.
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Efs-utils requires IMDS to find the region of a file system. We will change this in a future release of efs-utils, but for now, we have to roll back and add host network back to the Node Daemonset.
k8s-ci-robot
added
cncf-cla: yes
|
Hi @seanzatzdev-amazon. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XXL
|
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
seanzatzdev-amazon
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mskanth972, seanzatzdev-amazon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
10 participants
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it?
Adds the following PRs to branch
release-1.7:What testing is done?
E2E, unit tests