Better control over log verbosity.#969
Better control over log verbosity.#969michalschott wants to merge 1 commit intokubernetes-sigs:masterfrom michalschott:master
Conversation
|
Welcome @michalschott! |
|
Hi @michalschott. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: michalschott The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
krmichel
left a comment
There was a problem hiding this comment.
I am currently working on PR #965 that will reorganize some of the sidecar-related values. I believe that these additional log level values would fit better in the new structure. What do you think about one of these options?
- I incorporate these changes into that PR
- You wait until after those changes to make your PR so the values can be put in the better structure
|
I went ahead and made changes on PR #965 if you want to check them out. |
|
/ok-to-test I'm OK with merging this change as part of #965 , will simplify rebasing pain for all. |
|
Actioned all suggestions from above. |
|
@michalschott: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@michalschott: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Yay, looks like this one is no longer required. Thanks! |
Is this a bug fix or adding new feature?
This is chart update.
What is this PR about? / Why do we need it?
This PR will allow to have more control over log verbosity.
What testing is done?
Chart has been templated and applied against local kind cluster.