Skip to content

Better control over log verbosity.#969

Closed
michalschott wants to merge 1 commit intokubernetes-sigs:masterfrom
michalschott:master
Closed

Better control over log verbosity.#969
michalschott wants to merge 1 commit intokubernetes-sigs:masterfrom
michalschott:master

Conversation

@michalschott
Copy link
Copy Markdown

Is this a bug fix or adding new feature?
This is chart update.

What is this PR about? / Why do we need it?
This PR will allow to have more control over log verbosity.

What testing is done?
Chart has been templated and applied against local kind cluster.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 8, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @michalschott!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @michalschott. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michalschott
To complete the pull request process, please assign vdhanan after the PR has been reviewed.
You can assign the PR to them by writing /assign @vdhanan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 8, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 8, 2021
Copy link
Copy Markdown
Contributor

@krmichel krmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am currently working on PR #965 that will reorganize some of the sidecar-related values. I believe that these additional log level values would fit better in the new structure. What do you think about one of these options?

  1. I incorporate these changes into that PR
  2. You wait until after those changes to make your PR so the values can be put in the better structure

Comment thread charts/aws-ebs-csi-driver/templates/controller.yaml Outdated
Comment thread charts/aws-ebs-csi-driver/templates/node.yaml Outdated
Comment thread charts/aws-ebs-csi-driver/templates/node-windows.yaml Outdated
Comment thread charts/aws-ebs-csi-driver/templates/node-windows.yaml Outdated
Comment thread charts/aws-ebs-csi-driver/templates/node-windows.yaml Outdated
Comment thread charts/aws-ebs-csi-driver/templates/snapshot-controller.yaml Outdated
Comment thread charts/aws-ebs-csi-driver/values.yaml Outdated
Comment thread charts/aws-ebs-csi-driver/values.yaml Outdated
@krmichel
Copy link
Copy Markdown
Contributor

krmichel commented Jul 9, 2021

I went ahead and made changes on PR #965 if you want to check them out.

@wongma7
Copy link
Copy Markdown

wongma7 commented Jul 12, 2021

/ok-to-test

I'm OK with merging this change as part of #965 , will simplify rebasing pain for all.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 12, 2021
@michalschott
Copy link
Copy Markdown
Author

Actioned all suggestions from above.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@michalschott: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-aws-ebs-csi-driver-external-test 529e820 link /test pull-aws-ebs-csi-driver-external-test
pull-aws-ebs-csi-driver-e2e-single-az 529e820 link /test pull-aws-ebs-csi-driver-e2e-single-az
pull-aws-ebs-csi-driver-e2e-multi-az 529e820 link /test pull-aws-ebs-csi-driver-e2e-multi-az
pull-aws-ebs-csi-driver-migration-test 529e820 link /test pull-aws-ebs-csi-driver-migration-test
pull-aws-ebs-csi-driver-external-test-eks 529e820 link /test pull-aws-ebs-csi-driver-external-test-eks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@michalschott: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michalschott
Copy link
Copy Markdown
Author

Yay, looks like this one is no longer required. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants