Skip to content

fix: improve logging for http-connect mode#758

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
kinvolk:imran/improve-logs-for-http-connectwq
Jul 31, 2025
Merged

fix: improve logging for http-connect mode#758
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
kinvolk:imran/improve-logs-for-http-connectwq

Conversation

@ipochi
Copy link
Copy Markdown
Contributor

@ipochi ipochi commented Jul 17, 2025

Improves the logging by adding dialId, agentID and connectionID to certain error mesages.

Signed-off-by: Imran Pochi <imranpochi@microsoft.com>
@k8s-ci-robot k8s-ci-robot requested a review from elmiko July 17, 2025 23:30
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ipochi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from tallclair July 17, 2025 23:30
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 17, 2025
@jkh52
Copy link
Copy Markdown
Contributor

jkh52 commented Jul 31, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3e5ed79 into kubernetes-sigs:master Jul 31, 2025
22 checks passed
ipochi pushed a commit to kinvolk/apiserver-network-proxy that referenced this pull request Aug 21, 2025
…s-for-http-connectwq

fix: improve logging for http-connect mode
(cherry picked from commit 3e5ed79)
ipochi pushed a commit to kinvolk/apiserver-network-proxy that referenced this pull request Aug 21, 2025
…s-for-http-connectwq

fix: improve logging for http-connect mode
(cherry picked from commit 3e5ed79)
ipochi pushed a commit to kinvolk/apiserver-network-proxy that referenced this pull request Aug 21, 2025
…s-for-http-connectwq

fix: improve logging for http-connect mode
(cherry picked from commit 3e5ed79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants