metadata: if value in cluster profile is empty, return error #1335
Conversation
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AlbeeSo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
AlbeeSo
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| @@ -27,7 +27,9 @@ func NewProfileMetadata(client kubernetes.Interface) (*ProfileMetadata, error) { | |||
|
|
|||
| func (m *ProfileMetadata) Get(key MetadataKey) (string, error) { | |||
| if key, ok := MetadataProfileDataKeys[key]; ok { | |||
| return m.profile.Data[key], nil | |||
| if m.profile.Data[key] != "" { | |||
There was a problem hiding this comment.
It's unreasonable to return ErrUnknownMetadataKey for an empty value; please use a new error code instead.
There was a problem hiding this comment.
I think this is appropriate. Golang returns empty string if the key does not exist in the map. In this case, ErrUnknownMetadataKey will trigger fallback to another source, which is expected.
There was a problem hiding this comment.
Just "unknown" for this source as keys are not found in cluster-profile.
In Private Cloud, cluster profile only has clusterId and resourceGroupId key.
ack-cluster-profile provider should return error to avoid a nil string, and allow the following providers to keep trying retrieve the values.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: