disk: only use diff for disks without serial number #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/cleanup
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
huww98
force-pushed
the
disk-force-serial
branch
from
0c17f41 to
56b659a
Compare
huww98
force-pushed
the
disk-force-serial
branch
from
56b659a to
e23d6d0
Compare
k8s-ci-robot
added
size/XXL
huww98
force-pushed
the
disk-force-serial
branch
5 times, most recently
from
20390c4 to
06594b6
Compare
Don't assume the serial is the volume ID without "d-" prefix.
Eliminate the risk of finding the wrong disk. It may take a while for the disk device to appear after the OpenAPI returns in_use. e.g. when the previous detach is blocked, the attach will also be blocked.
huww98
force-pushed
the
disk-force-serial
branch
from
06594b6 to
14396be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Eliminate the risk of finding the wrong disk. It may take a while for the disk device to appear after the OpenAPI returns in_use. e.g. when the previous detach is blocked, the attach will also be blocked.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: