This repository was archived by the owner on May 6, 2022. It is now read-only.
Stop sending accepts_incomplete in provision request body#933
Closed
pmorie wants to merge 1 commit into
Closed
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
@pmorie I'd like to get this tested against the fake broker server. Can we get that merged first, and then add those tests in here? |
Contributor
|
Instead of adding a new type that's only local to this file, I think we should just remove the field from the /pkg/brokerapi/service_instance.go since it's always hard coded to true and it is incorrectly defined there anyways. |
Contributor
Author
|
I'm going to close this, since it will be fixed naturally by #940 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #932