This repository was archived by the owner on May 6, 2022. It is now read-only.
Support for OSB PR #452 to allow periods in the name field#1835
Closed
amshuman-kr wants to merge 1 commit into
Closed
Support for OSB PR #452 to allow periods in the name field#1835amshuman-kr wants to merge 1 commit into
amshuman-kr wants to merge 1 commit into
Conversation
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
Can we get some testcases? Also, does the "." need to be escaped so its not treated as "any char"? |
Contributor
Author
|
Needs more work. |
Contributor
Author
|
Sorry. Wrongly submitted the PR too early. I will raise a new one once I have verified it and also added test cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for OSB PR #452.