Adding walkthrough instructions for 1.7#1171
Conversation
k8s-ci-robot
added
cncf-cla: yes
kibbles-n-bytes
left a comment
kibbles-n-bytes
left a comment
There was a problem hiding this comment.
Resource renames + one lingering context reference
| `kubectl get` will return an empty list of resources. | ||
|
|
||
| ```console | ||
| kubectl get brokers,serviceclasses,instances,bindings |
There was a problem hiding this comment.
brokers, instances, bindings -> servicebrokers, serviceinstances, servicebindings
| Do so with the following command: | ||
|
|
||
| ```console | ||
| kubectl --context=service-catalog create -f contrib/examples/walkthrough/ups-broker.yaml |
There was a problem hiding this comment.
We don't need the context anymore here I think.
| The output of that command should be the following: | ||
|
|
||
| ```console | ||
| broker "ups-broker" created |
| We can check the status of the broker using `kubectl get`: | ||
|
|
||
| ```console | ||
| kubectl get brokers ups-broker -o yaml |
| Check the status of that process with this command: | ||
|
|
||
| ```console | ||
| kubectl get instances -n test-ns ups-instance -o yaml |
| `ServiceInstanceCredential` resource that we previously created: | ||
|
|
||
| ```console | ||
| kubectl delete -n test-ns bindings ups-instance-credential |
| `ServiceInstance` resource that we previously created: | ||
|
|
||
| ```console | ||
| kubectl delete -n test-ns instances ups-instance |
| command: | ||
|
|
||
| ```console | ||
| kubectl delete brokers ups-broker |
|
Thanks for catching all the incorrect resource names @kibbles-n-bytes - I addressed all your comments. |
|
No problem. LGTM! |
| # Step 1 - Installing the UPS Broker Server | ||
|
|
||
| In order to effectively demonstrate the service catalog, we need a sample | ||
| broker server. We've built a "dummy" server called the User Provided Service |
There was a problem hiding this comment.
I feel like 'we' changes value between sentences here, maybe I'm misreading things though. Is the second sentence better put as "to illustrate the concept of a broker, we'll use a "dummy" server" ?
There was a problem hiding this comment.
good catch, I modified the wording to only use "we" to indicate the person running through the demo
|
@pmorie I addressed your comment. Can you take another look? |
arschles
force-pushed
the
walkthrough-1.7
branch
from
2f3e2e0 to
7b5d7d4
Compare
pmorie
left a comment
pmorie
left a comment
There was a problem hiding this comment.
I still think it's a little weird that we use the term 'ServiceInstanceCredential' with the bind/unbind verbs, but we can sort that out later.
4 participants
This is a follow-up to #1163