This repository was archived by the owner on May 6, 2022. It is now read-only.
Specifying that you need Helm v2.5.0 for installation#1170
Merged
Conversation
This is a follow-up to kubernetes-retired#1163 (comment) sion_r135920291 Cc/ @MHBauer
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
LGTM |
Contributor
|
@arschles Thanks for following up! |
nilebox
reviewed
Aug 30, 2017
| below. | ||
|
|
||
| If you already have Helm v2 or newer, execute `helm init` (if you haven't | ||
| If you already have Helm v2.5.0 or newer, execute `helm init` (if you haven't |
Contributor
There was a problem hiding this comment.
Repeating the version 3 times in a single section looks a bit redundant to me, I would leave if only for the first mention and omit the version completely in all other places
nilebox
reviewed
Aug 30, 2017
| be done with Helm setup. | ||
|
|
||
| If you don't already have Helm v2, see the | ||
| If you don't already have Helm v2.5.0, see the |
Contributor
Author
|
@nilebox I've addressed your comments. If the changes are acceptable, can you merge (pending CI)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1163 (comment)
Cc/ @MHBauer