This repository was archived by the owner on May 6, 2022. It is now read-only.
update apiregistration yaml to v1.7 final#1011
Merged
arschles merged 1 commit intoJul 7, 2017
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
Author
arschles
approved these changes
Jul 7, 2017
Contributor
Author
|
@cheftako this is an example of the things we need to keep in sync on. |
| {{ if .Capabilities.APIVersions.Has "apiregistration.k8s.io/v1alpha1" -}} | ||
| priority: 100 | ||
| {{ else if .Capabilities.APIVersions.Has "apiregistration.k8s.io/v1beta1" -}} | ||
| groupPriorityMinimum: 10000 |
Contributor
There was a problem hiding this comment.
Looks straightforward, though could we get an explanation as to why these priority values were chosen?
Contributor
There was a problem hiding this comment.
@kibbles-n-bytes check out https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kube-aggregator/pkg/apis/apiregistration/v1beta1/types.go#L56-L71 for documentation on generally what these should be. I believe that, in a follow-up, we should parameterize these. Not blocking for this PR.
Contributor
|
@MHBauer I have removed the |
Contributor
Author
|
Sorry on jumping the gun there @arschles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
right now we're broken without the priority existing correctly for 1.7