Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

rktlet/mounts: support for terminationMessagePath #102

Closed
wants to merge 1 commit into from

Conversation

s-urbaniak
Copy link

This adds support for reading the terminationMessagePath letting some
e2e node conformance tests pass.

Blocked by rkt/rkt#3571

This adds support for reading the terminationMessagePath letting some
e2e node conformance tests pass.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2017
@lucab
Copy link
Contributor

lucab commented Feb 1, 2017

Would you mind:

  • marking and cross-referencing tests in Conformance testing #95 (if I'm not wrong count should go +5 up)
  • a small integration test for this, to avoid future regressions

The rkt side of this got merged already, so Ci can pick it up tomorrow from rkt-nightly and it will be in 1.24.0 as well.

@squeed squeed mentioned this pull request Feb 1, 2017
20 tasks
@s-urbaniak
Copy link
Author

point 1 (marking and cross-referencing) is done

@s-urbaniak
Copy link
Author

Oh great ... I should have listened to @squeed more closely, we don't need to read the termination message at all, since the upper kube runtime does it for us: https://github.com/kubernetes/kubernetes/blob/c436671cca6f2ecff3674e64ef219e4fff02b2a3/pkg/kubelet/kuberuntime/kuberuntime_container.go#L414

All is needed is the rkt fix.

@s-urbaniak
Copy link
Author

verified, the conformance tests pass with the rkt fix only, closing the PR.

@s-urbaniak s-urbaniak closed this Feb 1, 2017
@iaguis iaguis added this to the v0.1.0 milestone Nov 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants