This repository was archived by the owner on Oct 29, 2025. It is now read-only.
Validate KRM Function metadata #8
Closed
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
natasha41575
force-pushed
the
verify-meta
branch
2 times, most recently
from
ead8ed7 to
a205b77
Compare
natasha41575
commented
Mar 2, 2022
|
Marking this as a draft until #6 is in |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
natasha41575
force-pushed
the
verify-meta
branch
from
a205b77 to
cbf69b5
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: natasha41575 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #6. The first 3 commits here are the 3 commits in #6. I split it out to make review more manageable - #6 should come first and then I will rebase this PR on it.
The last commit here adds a CI check to validate the KRM function metadata based on the openapi schema of KRMFunctionDefinition as defined in the Catalog KEP. I can confirm that it works because it caught some of my mistakes in defining the render-helm-chart function definition 😁
/cc @KnVerey
/cc @jeremyrickard
/cc @mengqiy