Skip to content
This repository has been archived by the owner on Dec 1, 2018. It is now read-only.

Log sink for events #816

Merged
merged 1 commit into from
Dec 23, 2015
Merged

Log sink for events #816

merged 1 commit into from
Dec 23, 2015

Conversation

mwielgus
Copy link
Contributor

cc: @piosz

@k8s-bot
Copy link

k8s-bot commented Dec 22, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@huangyuqi
Copy link

Hi, @mwielgus I inadvertently found this heapster-scalability branch , is there a reconstruction plan of heapster in community? would you please share me some details about this. Thanks so much.

@mwielgus
Copy link
Contributor Author

Yes, we are significantly refactoring Heapster. It was announced in #684.
More details on the future of Heapster can be also found here: #769

gmarek
gmarek reviewed Dec 23, 2015
View reviewed changes
events/sinks/log/log_sink.go

func batchToString(batch *core.EventBatch) string {
var buffer bytes.Buffer
buffer.WriteString(fmt.Sprintf("EventBatch Timestamp: %s\n", batch.Timestamp))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An idea: maybe use text/tabwriter for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for debugging. No need for aligning.

@gmarek
Copy link
Contributor

gmarek commented Dec 23, 2015

One suggestion, but otherwise LGTM. Ping me if you decide to use tabwriter.

mwielgus added a commit that referenced this pull request Dec 23, 2015
@mwielgus
Merge pull request #816 from mwielgus/log-sink-events
07f1d7d 
Log sink for events
@mwielgus mwielgus merged commit 07f1d7d into kubernetes-retired:heapster-scalability Dec 23, 2015
@huangyuqi
Copy link

Thanks, @mwielgus , shall I join some Heapster refactoring contribution work? Or assign me some task about this? ^_^

@mwielgus
Copy link
Contributor Author

Sure, any help will be more than welcome. I will try to produce a list of pending tasks Today but if I don't (Christmas is coming) you can start with porting Kafka and Riemann sinks to the new api.

@huangyuqi
Copy link

Thanks so much for letting me join. ^_^
May you have the best Christmas ever. @mwielgus
I will invest in the porting work today and wait for your pending tasks list.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mwielgus @k8s-bot @huangyuqi @gmarek @googlebot