Skip to content
This repository has been archived by the owner on Dec 9, 2020. It is now read-only.

Migrate flex adapter from drivers #3

Merged
merged 87 commits into from
Jun 5, 2019
Merged

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented May 29, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

  • import release-tools (git subtree add --prefix=release-tools https://github.com/kubernetes-csi/csi-release-tools.git master)
  • merge flexadapter related commits from drivers (failed because original commits does not pass cla check)
    • git clone [email protected]:kubernetes-csi/drivers.git
    • git filter-branch --index-filter 'git rm --cached -qr --ignore-unmatch -- . && git reset -q $GIT_COMMIT -- app/flexadapter pkg/flexadapter' --prune-empty -- --all
  • copy flexadapter files from drivers
  • update docs and vendor dependencies

Which issue(s) this PR fixes:

Fixes #1

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

chakri-nelluri and others added 30 commits November 15, 2017 15:28
Refactor to app & pkg directories
Add some unit tests & improve logging
Use mountdevice callout based on plugin capability
Refactor drivers to CSI 0.2.0 spec
refactor csi-common and hostpath plugin  to use new api objects
This patch updates the README for plugins for CSI 0.2.0.
It includes the following changes:
- Updates the CSC tool location
- Removes "get supported versions" because that was removed
  from CSI.
Update drivers to pick up CSI 1.0.0
The repo was created with an HTML version of the build.make file from
https://github.com/pohly/csi-build-rules/. Here's the raw file.
It's worth calling out explicitly that only the master branch is
maintained.
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 29, 2019
@cofyc
Copy link
Contributor Author

cofyc commented May 29, 2019

/assign @msau42

@cofyc
Copy link
Contributor Author

cofyc commented May 29, 2019

/assign @chakri-nelluri

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 29, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 29, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 29, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 29, 2019
@msau42
Copy link
Contributor

msau42 commented Jun 5, 2019

@pohly could you help verify the release-tools import was done correctly?

@pohly
Copy link
Contributor

pohly commented Jun 5, 2019

merge flexadapter related commits from drivers - failed because original commits does not pass cla check

We've had that before and it was agreed to by-pass the CLA check (kubernetes-csi/csi-driver-host-path#1) - I personally prefer that over loosing history.

could you help verify the release-tools import was done correctly?

Yes, all looks good and make test passes (which includes checking the release-tools directory).

@cofyc
Copy link
Contributor Author

cofyc commented Jun 5, 2019

OK, I'll update it.

@cofyc
Copy link
Contributor Author

cofyc commented Jun 5, 2019

I think it's better to keep the original commits too.
Reverted back to 30eddaa. PTAL.

@msau42
Copy link
Contributor

msau42 commented Jun 5, 2019

/lgtm
/approve

Force merging to skip cla check

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cofyc, msau42
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: childsb

If they are not already assigned, you can assign the PR to them by writing /assign @childsb in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msau42 msau42 merged commit 7cb43e1 into kubernetes-retired:master Jun 5, 2019
@msau42
Copy link
Contributor

msau42 commented Jun 5, 2019

@cofyc can you also help setup test-infra for this repo? Maybe just enable unit test jobs for now until we're ready for image building.

https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes-csi

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate flex adapter from drivers