This repository was archived by the owner on Jul 30, 2021. It is now read-only.
Makefile: Actually use 'go install ...' for the install target #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
k8s-ci-robot
added
the
cncf-cla: yes
This was my intention with dbf0b6a (Makefile: Use 'go install ...' for the install target, 2018-04-03, kubernetes-retired#949), but I seem to have missed the actual code :/. Instead, that commit landed an earlier implementation which we intended to drop based on kubernetes-retired#949 review [1]. This commit has the intended implementation. For detailed motivation, see the description in dbf0b6a. [1]: kubernetes-retired#949 (comment)
k8s-ci-robot
added
the
size/XS
|
CC @rphillips, @ericchiang. |
rphillips
approved these changes
Apr 3, 2018
|
thanks! |
This was referenced Apr 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was my intention with #949, but I seem to have missed the actual code :/. Instead, that pull-request landed an earlier implementation which we intended to drop based on #949 review.
This commit has the intended implementation. For detailed motivation, see the description in dbf0b6a.