Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

*: update etcd-operator and etcd version #461

Merged
merged 2 commits into from
Apr 24, 2017
Merged

*: update etcd-operator and etcd version #461

merged 2 commits into from
Apr 24, 2017

Conversation

hongchaodeng
Copy link
Contributor

@hongchaodeng hongchaodeng commented Apr 21, 2017 •
edited
Loading

This PR is to update image versions of etcd-operator, etcd.
The latest etcd-operator release also fixes scale test, reboot test due to 1.6 upgrade.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 21, 2017
@peebs
Copy link

peebs commented Apr 21, 2017

rktbot run tests

@peebs
Copy link

peebs commented Apr 21, 2017

rktbot run disabled tests

2 similar comments
@peebs
Copy link

peebs commented Apr 21, 2017

rktbot run disabled tests

@hongchaodeng
Copy link
Contributor Author

rktbot run disabled tests

@peebs
Copy link

peebs commented Apr 21, 2017

Looking good. Just need to wait until etcd-operator cuts a release we can use.

@hongchaodeng
Copy link
Contributor Author

rktbot run disabled tests

@hongchaodeng
Copy link
Contributor Author

rktbot run tests

@hongchaodeng hongchaodeng changed the title *: update etcd-operator and etcd version [FOR TESTING] *: update etcd-operator and etcd version Apr 22, 2017
@xiang90
Copy link
Contributor

xiang90 commented Apr 22, 2017

@hongchaodeng

can you revert f942073 to see if taint works correctly on multi-node example?

@pbx0

can you try to enable the taint flag on our testing infra to see if all tests can still pass?

@hongchaodeng
Copy link
Contributor Author

@xiang90
Tested taint and it (multi-node) worked. Commits pushed here.

@xiang90
Copy link
Contributor

xiang90 commented Apr 22, 2017

@hongchaodeng Thanks!

@peebs
Copy link

peebs commented Apr 24, 2017

rktbot run disabled tests

@Quentin-M
Copy link
Contributor

Quentin-M commented Apr 24, 2017 •
edited
Loading

Hey.

How is this progressing?
Trying to get coreos/tectonic-installer#135 wrapped up by tomorrow.
/cc @sym3tri

@hongchaodeng
Copy link
Contributor Author

@Quentin-M
We have all the code ready.
We have done the testing last week without taints.
Now we are going through testing with taints. If things go well, we will cut a release in etcd operator and then update this PR.

@peebs
Copy link

peebs commented Apr 24, 2017

rktbot run disabled tests

@peebs
Copy link

peebs commented Apr 24, 2017

Looking good so far. Both the disabled tests pass on this branch and fail on master. So this fixes the scale test and the reboot test for self-hosted etcd clusters.

@hongchaodeng hongchaodeng changed the title [FOR TESTING] *: update etcd-operator and etcd version *: update etcd-operator and etcd version Apr 24, 2017
@hongchaodeng
Copy link
Contributor Author

etcd-operator v0.2.5 is cut.
Updated PR.

@xiang90 @pbx0 @aaronlevy @squat

@aaronlevy
Copy link
Contributor

@hongchaodeng sorry -- didn't see this and just changed vendoring to glide -- can you update this PR with the etcd-operator pinned in the new glide.yaml

aaronlevy
aaronlevy reviewed Apr 24, 2017
View reviewed changes
hack/multi-node/user-data.sample Outdated
@@ -32,6 +32,7 @@ coreos:
--allow-privileged \
--hostname-override=${COREOS_PUBLIC_IPV4} \
--node-labels=node-role.kubernetes.io/master \
--register-with-taints=node-role.kubernetes.io/master=:NoSchedule \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing

aaronlevy
aaronlevy reviewed Apr 24, 2017
View reviewed changes
hack/quickstart/init-master.sh
@@ -23,7 +23,7 @@ function configure_etcd() {
mkdir -p /etc/systemd/system/etcd-member.service.d
cat << EOF > /etc/systemd/system/etcd-member.service.d/10-etcd-member.conf
[Service]
Environment="ETCD_IMAGE_TAG=v3.1.0"
Environment="ETCD_IMAGE_TAG=v3.1.6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to pin this version in the vendored client code too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We should pin this in glide.yaml.
Bootkube seems to vendor latest etcd and etcd-operator version already. We don't need to update in this PR. I would like to pin in separate PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@hongchaodeng
Copy link
Contributor Author

rktbot run disabled tests

aaronlevy
aaronlevy approved these changes Apr 24, 2017
View reviewed changes
Copy link
Contributor

@aaronlevy aaronlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass, lgtm

peebs
peebs approved these changes Apr 24, 2017
View reviewed changes
Copy link

@peebs peebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hongchaodeng hongchaodeng merged commit c2b2959 into kubernetes-retired:master Apr 24, 2017
@hongchaodeng hongchaodeng deleted the fix branch April 24, 2017 21:09
@aaronlevy aaronlevy mentioned this pull request Apr 24, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@peebs peebs peebs approved these changes

@aaronlevy aaronlevy aaronlevy approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hongchaodeng @peebs @xiang90 @Quentin-M @aaronlevy @k8s-ci-robot