-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Exoscale as Provider #625
Added Exoscale as Provider #625
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Yoan Blanc <[email protected]>
465e8a8
to
a487d38
Compare
Signed the CLA and changed my author email accordingly. |
@FaKod my e-mail address should be okay as well. |
Thank for your PR @FaKod 🙂 It would be nice to have a tutorial to get started with Exoscale. I'll have a look at the code. |
} | ||
} | ||
} | ||
for _, epoint := range changes.UpdateNew { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to understand it a bit better, why do you ignore the updates? I just only see that you're looping over update changes even if you would use a logging level which is not debug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must admit that for my use case it seems to be sufficient to only support create and delete. Is update mandatory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just only asking because I never saw that someone wouldn't want to update their records. Could there people which might need it?
If you don't use it at all I'm not seeing any point looping over updates which doesn't do anything execept logging.
@njuettner I've added UpdateNew, while still iterating over UpdateOld, just for logging reasons (like it is done in pdns.go) |
The label docs-missing means actually tutorial missing? |
@FaKod yes sorry for the confusion. Tutorial is missing, do you mind to add it as well and add it also in the README.md. There are already other links pointing to the provider tutorials. |
@njuettner for the tutorial... Which external-dns version should I refer to? |
v0.5.5 |
@FaKod it's looks like the tests are failing in types.go. Could you take a look again? |
Signed-off-by: Yoan Blanc <[email protected]>
exoscale: fix boilerplate header
@njuettner Sorry... should work now |
/LGTM |
verbs: ["get","watch","list"] | ||
- apiGroups: ["extensions"] | ||
resources: ["ingresses"] | ||
verbs: ["get","watch","list"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I wasn't seeing it but you have to add
- apiGroups: [""]
resources: ["nodes"]
verbs: ["list"]
to run external-dns with RBAC
Thanks again for your PR! |
Exoscale is a trademark of Akenes SA, a private company founded in 2011 and headquartered in Switzerland. My company uses their cloud offers to host Kubernetes clusters.
With this PR I implemented Exoscale's DNS API as additional provider.
Let me know what you think...