Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/external-dns] Add exoscale external-dns values #15837

Merged
merged 1 commit into from
Apr 3, 2023
Merged

[bitnami/external-dns] Add exoscale external-dns values #15837

merged 1 commit into from
Apr 3, 2023

Conversation

jonesbusy
Copy link
Contributor

Description of the change

Add exoscale external dns values supported by kubernetes-sigs/external-dns#625

Benefits

Support for exoscale cloud provider

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@jonesbusy
Copy link
Contributor Author

Test done on SKS cluster and Exoscale DNS

helm upgrade --install --namespace external-dns --version 6.16.0 --set dryRun=false --set logLevel=debug  --set provider=exoscale --set exoscale.apiKey=$EXOSCALE_API_KEY --set exoscale.apiToken=$EXOSCALE_API_SECRET external-dns external-dns-6.16.0.tgz
kubectl run nginx --image=nginx --port=80
kubectl expose pod nginx --port=80 --target-port=80 --type=LoadBalancer
kubectl annotate service nginx "external-dns.alpha.kubernetes.io/hostname=nginx.<zone>."

external_dns_exoscale

Signed-off-by: Valentin Delaye <[email protected]>
@jonesbusy
Copy link
Contributor Author

Rebased to resolve conflict on chart version

@javsalgar javsalgar added the verify Execute verification workflow for these changes label Apr 3, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Apr 3, 2023
@bitnami-bot bitnami-bot removed the request for review from javsalgar April 3, 2023 08:58
@bitnami-bot bitnami-bot requested a review from Mauraza April 3, 2023 08:58
Copy link
Contributor

@Mauraza Mauraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jonesbusy,

Thanks for the contribution! LGTM!

@Mauraza Mauraza merged commit 8facec5 into bitnami:main Apr 3, 2023
@jonesbusy jonesbusy deleted the feature/external-dns-exoscale branch April 3, 2023 11:32
mr-onion-2 pushed a commit to mr-onion-2/bitnami-charts that referenced this pull request Apr 3, 2023
Signed-off-by: Valentin Delaye <[email protected]>
Signed-off-by: Montgomery Orange <[email protected]>
mr-onion-2 pushed a commit to mr-onion-2/bitnami-charts that referenced this pull request Apr 3, 2023
Signed-off-by: Valentin Delaye <[email protected]>
Signed-off-by: Montgomery Orange <[email protected]>
Mauraza pushed a commit that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-dns solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/external-dns] Support for Exoscale provider
3 participants